Re: [libvirt] [PATCH v3 2/2] conf: Use virStringParseYesNo()

2019-03-13 Thread Erik Skultety
On Wed, Mar 13, 2019 at 03:30:11PM +0900, Shotaro Gotanda wrote: > this commit remove redundant common pattern in our XML parsing. I appreciate splitting the changes for review purposes, most of the time it's a very good practice which makes the reviewer's life easier, but this was a very simple

[libvirt] [PATCH v3 2/2] conf: Use virStringParseYesNo()

2019-03-13 Thread Shotaro Gotanda
this commit remove redundant common pattern in our XML parsing. Signed-off-by: Shotaro Gotanda --- src/conf/domain_conf.c | 30 +- src/conf/secret_conf.c | 12 ++-- 2 files changed, 7 insertions(+), 35 deletions(-) diff --git a/src/conf/domain_conf.c