Re: [libvirt] [PATCH v3 2/2] security: Refactor virSecurityManagerGenLabel

2015-02-13 Thread Ján Tomko
On Thu, Feb 12, 2015 at 06:32:41PM +0100, Erik Skultety wrote: if (mgr == NULL || mgr-drv == NULL) return ret; This check isn't really necessary, security manager cannot be a NULL pointer as it is either selinux (by default) or 'none', if no other driver is set in the config. Even with

[libvirt] [PATCH v3 2/2] security: Refactor virSecurityManagerGenLabel

2015-02-12 Thread Erik Skultety
if (mgr == NULL || mgr-drv == NULL) return ret; This check isn't really necessary, security manager cannot be a NULL pointer as it is either selinux (by default) or 'none', if no other driver is set in the config. Even with no config file driver name yields 'none'. The other hunk checks for