[libvirt] [PATCH v3 2/2] virtlogd: add missing netserver refcount increment on reload

2017-10-24 Thread Nikolay Shirokovskiy
After virNetDaemonAddServerPostExec call in virtlogd we should have netserver refcount set to 2. One goes to netdaemon servers hashtable and one goes to virtlogd own reference to netserver. Let's add missing increment in virNetDaemonAddServerPostExec itself while holding daemon lock. We also have

Re: [libvirt] [PATCH v3 2/2] virtlogd: add missing netserver refcount increment on reload

2017-10-25 Thread John Ferlan
On 10/24/2017 06:47 AM, Nikolay Shirokovskiy wrote: > After virNetDaemonAddServerPostExec call in virtlogd we should have > netserver refcount set to 2. One goes to netdaemon servers hashtable > and one goes to virtlogd own reference to netserver. Let's add > missing increment in virNetDaemonAddS

Re: [libvirt] [PATCH v3 2/2] virtlogd: add missing netserver refcount increment on reload

2017-10-25 Thread Nikolay Shirokovskiy
On 25.10.2017 12:06, John Ferlan wrote: > > > On 10/24/2017 06:47 AM, Nikolay Shirokovskiy wrote: >> After virNetDaemonAddServerPostExec call in virtlogd we should have >> netserver refcount set to 2. One goes to netdaemon servers hashtable >> and one goes to virtlogd own reference to netserver

Re: [libvirt] [PATCH v3 2/2] virtlogd: add missing netserver refcount increment on reload

2017-10-25 Thread John Ferlan
On 10/25/2017 05:15 AM, Nikolay Shirokovskiy wrote: > > > On 25.10.2017 12:06, John Ferlan wrote: >> >> >> On 10/24/2017 06:47 AM, Nikolay Shirokovskiy wrote: >>> After virNetDaemonAddServerPostExec call in virtlogd we should have >>> netserver refcount set to 2. One goes to netdaemon servers h

Re: [libvirt] [PATCH v3 2/2] virtlogd: add missing netserver refcount increment on reload

2017-10-26 Thread John Ferlan
On 10/25/2017 05:48 AM, John Ferlan wrote: > > > On 10/25/2017 05:15 AM, Nikolay Shirokovskiy wrote: >> >> >> On 25.10.2017 12:06, John Ferlan wrote: >>> >>> >>> On 10/24/2017 06:47 AM, Nikolay Shirokovskiy wrote: After virNetDaemonAddServerPostExec call in virtlogd we should have net

Re: [libvirt] [PATCH v3 2/2] virtlogd: add missing netserver refcount increment on reload

2017-10-27 Thread Erik Skultety
On Thu, Oct 26, 2017 at 09:14:02AM -0400, John Ferlan wrote: > > > On 10/25/2017 05:48 AM, John Ferlan wrote: > > > > > > On 10/25/2017 05:15 AM, Nikolay Shirokovskiy wrote: > >> > >> > >> On 25.10.2017 12:06, John Ferlan wrote: > >>> > >>> > >>> On 10/24/2017 06:47 AM, Nikolay Shirokovskiy wrote: