Re: [libvirt] [PATCH v3 2/4] refactor virStorageBackendSCSINewLun

2015-04-16 Thread Ján Tomko
On Tue, Apr 07, 2015 at 04:21:01PM -0400, John Ferlan wrote: This could use some comment about inverting the logic of the retval variable. Signed-off-by: John Ferlan jfer...@redhat.com --- src/storage/storage_backend_scsi.c | 55 ++ 1 file changed, 20

Re: [libvirt] [PATCH v3 2/4] refactor virStorageBackendSCSINewLun

2015-04-16 Thread John Ferlan
On 04/16/2015 08:35 AM, Ján Tomko wrote: On Tue, Apr 07, 2015 at 04:21:01PM -0400, John Ferlan wrote: This could use some comment about inverting the logic of the retval variable. Signed-off-by: John Ferlan jfer...@redhat.com --- src/storage/storage_backend_scsi.c | 55

[libvirt] [PATCH v3 2/4] refactor virStorageBackendSCSINewLun

2015-04-07 Thread John Ferlan
Signed-off-by: John Ferlan jfer...@redhat.com --- src/storage/storage_backend_scsi.c | 55 ++ 1 file changed, 20 insertions(+), 35 deletions(-) diff --git a/src/storage/storage_backend_scsi.c b/src/storage/storage_backend_scsi.c index 2a3e1e4..b96caec 100644