Re: [libvirt] [PATCH v3 2/5] util: virhostcpu: factor out frequency parsing

2018-01-08 Thread Andrea Bolognani
On Fri, 2018-01-05 at 15:41 -0500, John Ferlan wrote: > > src/util/virhostcpu.c | 141 > > ++ > > 1 file changed, 62 insertions(+), 79 deletions(-) > > Couple of nits... see below > > Reviewed-by: John Ferlan > > > diff

Re: [libvirt] [PATCH v3 2/5] util: virhostcpu: factor out frequency parsing

2018-01-05 Thread John Ferlan
On 12/14/2017 07:33 AM, Andrea Bolognani wrote: > From: Bjoern Walk > > All different architectures use the same copy-pasted code to parse > processor frequency information from /proc/cpuinfo. Let's extract that > code into a function to avoid repetition. > > We now

[libvirt] [PATCH v3 2/5] util: virhostcpu: factor out frequency parsing

2017-12-14 Thread Andrea Bolognani
From: Bjoern Walk All different architectures use the same copy-pasted code to parse processor frequency information from /proc/cpuinfo. Let's extract that code into a function to avoid repetition. We now also tolerate if the parsing of /proc/cpuinfo is not successful