Re: [libvirt] [PATCH v3 2/6] fdstream: Report error from the I/O thread

2017-06-13 Thread Michal Privoznik
On 06/13/2017 03:13 PM, John Ferlan wrote: > > > On 06/13/2017 07:31 AM, Michal Privoznik wrote: >> On 06/12/2017 11:48 PM, John Ferlan wrote: >>> >>> >>> On 06/05/2017 04:22 AM, Michal Privoznik wrote: Problem with our error reporting is that the error object is a thread local

Re: [libvirt] [PATCH v3 2/6] fdstream: Report error from the I/O thread

2017-06-13 Thread John Ferlan
On 06/13/2017 07:31 AM, Michal Privoznik wrote: > On 06/12/2017 11:48 PM, John Ferlan wrote: >> >> >> On 06/05/2017 04:22 AM, Michal Privoznik wrote: >>> Problem with our error reporting is that the error object is a >>> thread local variable. That means if there's an error reported >>> within

Re: [libvirt] [PATCH v3 2/6] fdstream: Report error from the I/O thread

2017-06-13 Thread Michal Privoznik
On 06/12/2017 11:48 PM, John Ferlan wrote: > > > On 06/05/2017 04:22 AM, Michal Privoznik wrote: >> Problem with our error reporting is that the error object is a >> thread local variable. That means if there's an error reported >> within the I/O thread it gets logged and everything, but later

Re: [libvirt] [PATCH v3 2/6] fdstream: Report error from the I/O thread

2017-06-12 Thread John Ferlan
On 06/05/2017 04:22 AM, Michal Privoznik wrote: > Problem with our error reporting is that the error object is a > thread local variable. That means if there's an error reported > within the I/O thread it gets logged and everything, but later > when the event loop aborts the stream it doesn't

[libvirt] [PATCH v3 2/6] fdstream: Report error from the I/O thread

2017-06-05 Thread Michal Privoznik
Problem with our error reporting is that the error object is a thread local variable. That means if there's an error reported within the I/O thread it gets logged and everything, but later when the event loop aborts the stream it doesn't see the original error. So we are left with some generic