Re: [libvirt] [PATCH v3 26/30] qemu_monitor_text: Catch IOMMU/VFIO related errors in qemuMonitorTextAddDrive

2019-12-13 Thread Cole Robinson
On 12/12/19 4:19 AM, Michal Privoznik wrote: > On 12/10/19 9:50 PM, Cole Robinson wrote: >> On 12/2/19 9:26 AM, Michal Privoznik wrote: >>> Because this is a HMP we're dealing with, there is nothing like >>> class of reply message, so we have to do some string comparison >>> to guess if the

Re: [libvirt] [PATCH v3 26/30] qemu_monitor_text: Catch IOMMU/VFIO related errors in qemuMonitorTextAddDrive

2019-12-12 Thread Michal Privoznik
On 12/10/19 9:50 PM, Cole Robinson wrote: On 12/2/19 9:26 AM, Michal Privoznik wrote: Because this is a HMP we're dealing with, there is nothing like class of reply message, so we have to do some string comparison to guess if the command fails. Well, with NVMe disks whole new class of errors

Re: [libvirt] [PATCH v3 26/30] qemu_monitor_text: Catch IOMMU/VFIO related errors in qemuMonitorTextAddDrive

2019-12-10 Thread Cole Robinson
On 12/2/19 9:26 AM, Michal Privoznik wrote: > Because this is a HMP we're dealing with, there is nothing like > class of reply message, so we have to do some string comparison > to guess if the command fails. Well, with NVMe disks whole new > class of errors comes to play because qemu needs to

[libvirt] [PATCH v3 26/30] qemu_monitor_text: Catch IOMMU/VFIO related errors in qemuMonitorTextAddDrive

2019-12-02 Thread Michal Privoznik
Because this is a HMP we're dealing with, there is nothing like class of reply message, so we have to do some string comparison to guess if the command fails. Well, with NVMe disks whole new class of errors comes to play because qemu needs to initialize IOMMU and VFIO for them. You can see all the