Re: [libvirt] [PATCH v3 3/3] qemu: Build command line for ivshmem device

2014-10-04 Thread Martin Kletzander
On Fri, Oct 03, 2014 at 03:36:19PM -0600, Eric Blake wrote: On 09/26/2014 04:43 AM, Martin Kletzander wrote: This patch implements support for the ivshmem device in QEMU. Signed-off-by: Maxime Leroy Signed-off-by: Martin Kletzander --- +virBufferAddLit(&buf, "ivshmem"); +if (shmem-

Re: [libvirt] [PATCH v3 3/3] qemu: Build command line for ivshmem device

2014-10-03 Thread Eric Blake
On 09/26/2014 04:43 AM, Martin Kletzander wrote: > This patch implements support for the ivshmem device in QEMU. > > Signed-off-by: Maxime Leroy > Signed-off-by: Martin Kletzander > --- > +virBufferAddLit(&buf, "ivshmem"); > +if (shmem->size) { > +/* > + * Thanks to our

Re: [libvirt] [PATCH v3 3/3] qemu: Build command line for ivshmem device

2014-09-26 Thread Martin Kletzander
On Fri, Sep 26, 2014 at 02:47:48PM +0200, Levente Kurusa wrote: Hi, On Fri, Sep 26, 2014 at 12:43:08PM +0200, Martin Kletzander wrote: This patch implements support for the ivshmem device in QEMU. Signed-off-by: Maxime Leroy Signed-off-by: Martin Kletzander --- - Nitpicks shall follow! :)

Re: [libvirt] [PATCH v3 3/3] qemu: Build command line for ivshmem device

2014-09-26 Thread Levente Kurusa
Hi, On Fri, Sep 26, 2014 at 12:43:08PM +0200, Martin Kletzander wrote: > This patch implements support for the ivshmem device in QEMU. > > Signed-off-by: Maxime Leroy > Signed-off-by: Martin Kletzander > --- > > - Nitpicks shall follow! :) What's this? > /* > * This method takes a string

[libvirt] [PATCH v3 3/3] qemu: Build command line for ivshmem device

2014-09-26 Thread Martin Kletzander
This patch implements support for the ivshmem device in QEMU. Signed-off-by: Maxime Leroy Signed-off-by: Martin Kletzander --- src/qemu/qemu_command.c| 118 - src/qemu/qemu_command.h| 1 + .../qemuxml2argv-shmem-inval