Re: [libvirt] [PATCH v3 3/3] security_dac: Favour ACLs over chown()

2013-03-12 Thread Daniel P. Berrange
On Mon, Mar 11, 2013 at 05:13:29PM +0100, Michal Privoznik wrote: On filesystems supporting ACLs we don't need to do a chown but we can just set ACLs to gain access for qemu. However, since we are setting these on too low level, where we don't know if disk is just a read only or read write, we

[libvirt] [PATCH v3 3/3] security_dac: Favour ACLs over chown()

2013-03-11 Thread Michal Privoznik
On filesystems supporting ACLs we don't need to do a chown but we can just set ACLs to gain access for qemu. However, since we are setting these on too low level, where we don't know if disk is just a read only or read write, we set read write access unconditionally. From implementation POV, a