Re: [libvirt] [PATCH v3 3/4] qemu_capabilities: Introduce QEMU_CAPS_PM_WAKEUP_SUPPORT

2019-04-18 Thread Michal Privoznik
On 4/17/19 8:27 PM, Daniel Henrique Barboza wrote: On 4/11/19 8:43 AM, Peter Krempa wrote: On Thu, Apr 11, 2019 at 13:37:49 +0200, Michal Privoznik wrote: On 4/11/19 12:12 PM, Daniel Henrique Barboza wrote: All that said, I think a good solution would be (2). dompmsuspend isn't a

Re: [libvirt] [PATCH v3 3/4] qemu_capabilities: Introduce QEMU_CAPS_PM_WAKEUP_SUPPORT

2019-04-17 Thread Daniel Henrique Barboza
On 4/11/19 8:43 AM, Peter Krempa wrote: On Thu, Apr 11, 2019 at 13:37:49 +0200, Michal Privoznik wrote: On 4/11/19 12:12 PM, Daniel Henrique Barboza wrote: All that said, I think a good solution would be (2). dompmsuspend isn't a performance sensitive command, thus the extra time to

Re: [libvirt] [PATCH v3 3/4] qemu_capabilities: Introduce QEMU_CAPS_PM_WAKEUP_SUPPORT

2019-04-11 Thread Peter Krempa
On Thu, Apr 11, 2019 at 13:49:03 +0200, Michal Privoznik wrote: > On 4/11/19 12:19 PM, Peter Krempa wrote: > > On Thu, Apr 11, 2019 at 11:58:04 +0200, Michal Privoznik wrote: > > > On 4/11/19 10:39 AM, Peter Krempa wrote: > > > > On Thu, Apr 11, 2019 at 10:25:11 +0200, Michal Privoznik wrote:

Re: [libvirt] [PATCH v3 3/4] qemu_capabilities: Introduce QEMU_CAPS_PM_WAKEUP_SUPPORT

2019-04-11 Thread Michal Privoznik
On 4/11/19 12:19 PM, Peter Krempa wrote: On Thu, Apr 11, 2019 at 11:58:04 +0200, Michal Privoznik wrote: On 4/11/19 10:39 AM, Peter Krempa wrote: On Thu, Apr 11, 2019 at 10:25:11 +0200, Michal Privoznik wrote: This capability tells whether qemu is capable of waking up the guest from PM

Re: [libvirt] [PATCH v3 3/4] qemu_capabilities: Introduce QEMU_CAPS_PM_WAKEUP_SUPPORT

2019-04-11 Thread Peter Krempa
On Thu, Apr 11, 2019 at 13:37:49 +0200, Michal Privoznik wrote: > On 4/11/19 12:12 PM, Daniel Henrique Barboza wrote: > > > > > > All that said, I think a good solution would be (2). dompmsuspend isn't a > > performance sensitive command, thus the extra time to execute the API > > can be ignored.

Re: [libvirt] [PATCH v3 3/4] qemu_capabilities: Introduce QEMU_CAPS_PM_WAKEUP_SUPPORT

2019-04-11 Thread Michal Privoznik
On 4/11/19 12:12 PM, Daniel Henrique Barboza wrote: > All that said, I think a good solution would be (2). dompmsuspend isn't a performance sensitive command, thus the extra time to execute the API can be ignored. Also, we can still check for QEMU_CAPS_QUERY_CURRENT_MACHINE inside

Re: [libvirt] [PATCH v3 3/4] qemu_capabilities: Introduce QEMU_CAPS_PM_WAKEUP_SUPPORT

2019-04-11 Thread Peter Krempa
On Thu, Apr 11, 2019 at 11:58:04 +0200, Michal Privoznik wrote: > On 4/11/19 10:39 AM, Peter Krempa wrote: > > On Thu, Apr 11, 2019 at 10:25:11 +0200, Michal Privoznik wrote: > > > This capability tells whether qemu is capable of waking up the > > > guest from PM suspend. > > > > > >

Re: [libvirt] [PATCH v3 3/4] qemu_capabilities: Introduce QEMU_CAPS_PM_WAKEUP_SUPPORT

2019-04-11 Thread Daniel Henrique Barboza
On 4/11/19 6:58 AM, Michal Privoznik wrote: On 4/11/19 10:39 AM, Peter Krempa wrote: On Thu, Apr 11, 2019 at 10:25:11 +0200, Michal Privoznik wrote: This capability tells whether qemu is capable of waking up the guest from PM suspend. Based-on-work-of: Daniel Henrique Barboza

Re: [libvirt] [PATCH v3 3/4] qemu_capabilities: Introduce QEMU_CAPS_PM_WAKEUP_SUPPORT

2019-04-11 Thread Michal Privoznik
On 4/11/19 10:39 AM, Peter Krempa wrote: On Thu, Apr 11, 2019 at 10:25:11 +0200, Michal Privoznik wrote: This capability tells whether qemu is capable of waking up the guest from PM suspend. Based-on-work-of: Daniel Henrique Barboza Signed-off-by: Michal Privoznik ---

Re: [libvirt] [PATCH v3 3/4] qemu_capabilities: Introduce QEMU_CAPS_PM_WAKEUP_SUPPORT

2019-04-11 Thread Peter Krempa
On Thu, Apr 11, 2019 at 10:25:11 +0200, Michal Privoznik wrote: > This capability tells whether qemu is capable of waking up the > guest from PM suspend. > > Based-on-work-of: Daniel Henrique Barboza > Signed-off-by: Michal Privoznik > --- > src/qemu/qemu_capabilities.c | 24

[libvirt] [PATCH v3 3/4] qemu_capabilities: Introduce QEMU_CAPS_PM_WAKEUP_SUPPORT

2019-04-11 Thread Michal Privoznik
This capability tells whether qemu is capable of waking up the guest from PM suspend. Based-on-work-of: Daniel Henrique Barboza Signed-off-by: Michal Privoznik --- src/qemu/qemu_capabilities.c | 24 +++ src/qemu/qemu_capabilities.h | 3 +++