Re: [libvirt] [PATCH v3 3/5] tools: console: add missing locks in callbacks

2019-04-04 Thread Nikolay Shirokovskiy
On 04.04.2019 17:48, Cole Robinson wrote: > On 4/4/19 2:57 AM, Nikolay Shirokovskiy wrote: >> >> >> On 03.04.2019 23:44, Cole Robinson wrote: >>> On 3/18/19 5:08 AM, Nikolay Shirokovskiy wrote: Stream/fd callbacks accessing console object are called from the event loop thread and the c

Re: [libvirt] [PATCH v3 3/5] tools: console: add missing locks in callbacks

2019-04-04 Thread Cole Robinson
On 4/4/19 2:57 AM, Nikolay Shirokovskiy wrote: > > > On 03.04.2019 23:44, Cole Robinson wrote: >> On 3/18/19 5:08 AM, Nikolay Shirokovskiy wrote: >>> Stream/fd callbacks accessing console object are called from the >>> event loop thread and the console object is also accessed from >>> the main th

Re: [libvirt] [PATCH v3 3/5] tools: console: add missing locks in callbacks

2019-04-03 Thread Nikolay Shirokovskiy
On 03.04.2019 23:44, Cole Robinson wrote: > On 3/18/19 5:08 AM, Nikolay Shirokovskiy wrote: >> Stream/fd callbacks accessing console object are called from the >> event loop thread and the console object is also accessed from >> the main thread so we are better add locking to handlers. >> >> Sig

Re: [libvirt] [PATCH v3 3/5] tools: console: add missing locks in callbacks

2019-04-03 Thread Cole Robinson
On 3/18/19 5:08 AM, Nikolay Shirokovskiy wrote: > Stream/fd callbacks accessing console object are called from the > event loop thread and the console object is also accessed from > the main thread so we are better add locking to handlers. > > Signed-off-by: Nikolay Shirokovskiy > --- > tools/vi

[libvirt] [PATCH v3 3/5] tools: console: add missing locks in callbacks

2019-03-18 Thread Nikolay Shirokovskiy
Stream/fd callbacks accessing console object are called from the event loop thread and the console object is also accessed from the main thread so we are better add locking to handlers. Signed-off-by: Nikolay Shirokovskiy --- tools/virsh-console.c | 35 +-- 1 file