Re: [libvirt] [PATCH v3 3/7] lib: introduce virDomainGetStateParams function

2019-04-04 Thread Bjoern Walk
Daniel P. Berrangé [2019-04-04, 11:41AM +0100]: > On Thu, Apr 04, 2019 at 10:01:30AM +0200, Bjoern Walk wrote: > > +virCheckDomainReturn(domain, -1); > > +if (params) > > +virCheckNonNullArgGoto(nparams, error); > > While I remember, we must forbid this for "read only" connections

Re: [libvirt] [PATCH v3 3/7] lib: introduce virDomainGetStateParams function

2019-04-04 Thread Daniel P . Berrangé
On Thu, Apr 04, 2019 at 10:01:30AM +0200, Bjoern Walk wrote: > This API function extends the virDomainGetState function by returning > additional state information as a dictionary of typed parameters. > > Reviewed-by: Boris Fiuczynski > Signed-off-by: Bjoern Walk > --- > include/libvirt/libvirt

[libvirt] [PATCH v3 3/7] lib: introduce virDomainGetStateParams function

2019-04-04 Thread Bjoern Walk
This API function extends the virDomainGetState function by returning additional state information as a dictionary of typed parameters. Reviewed-by: Boris Fiuczynski Signed-off-by: Bjoern Walk --- include/libvirt/libvirt-domain.h | 76 src/driver-hypervisor.h