Re: [libvirt] [PATCH v3 3/8] storage: Rework ret logic in storageBackendUpdateVolTargetInfo

2019-02-12 Thread Ján Tomko
On Tue, Feb 12, 2019 at 09:19:01AM -0500, John Ferlan wrote: Rather than overload @ret with trying serve multiple purposes, let's initialize @ret to -1 and introduce an @rc function return value that can be used for functions that may return -1 or -2 and only override @ret when rc < 0.

[libvirt] [PATCH v3 3/8] storage: Rework ret logic in storageBackendUpdateVolTargetInfo

2019-02-12 Thread John Ferlan
Rather than overload @ret with trying serve multiple purposes, let's initialize @ret to -1 and introduce an @rc function return value that can be used for functions that may return -1 or -2 and only override @ret when rc < 0. Signed-off-by: John Ferlan --- src/storage/storage_util.c | 30