[libvirt] [PATCH v3 4/4] add dump_memory_format in qemu.conf

2014-02-27 Thread qiaonuohan
This patch is used to add dump_memory_format to qemu.conf and libvirt will use it to specify the default format in which qemu dumps guest's memory. But when --compress is specified with virsh dump --memory-only, the format configured by dump_memory_format will be overrided. dump_memory_format can

Re: [libvirt] [PATCH v3 4/4] add dump_memory_format in qemu.conf

2014-02-27 Thread Daniel P. Berrange
On Thu, Feb 27, 2014 at 03:56:45PM +0800, qiaonuohan wrote: This patch is used to add dump_memory_format to qemu.conf and libvirt will use it to specify the default format in which qemu dumps guest's memory. But when --compress is specified with virsh dump --memory-only, the format configured

Re: [libvirt] [PATCH v3 4/4] add dump_memory_format in qemu.conf

2014-02-27 Thread Daniel P. Berrange
On Thu, Feb 27, 2014 at 08:52:19AM -0700, Eric Blake wrote: On 02/27/2014 07:55 AM, Daniel P. Berrange wrote: +else { +/* when --compress option is specified, qemu.conf will not work */ +cfg = virQEMUDriverGetConfig(driver); +if

Re: [libvirt] [PATCH v3 4/4] add dump_memory_format in qemu.conf

2014-02-27 Thread Eric Blake
On 02/27/2014 08:55 AM, Daniel P. Berrange wrote: Arguably, if you support value '0' as an explicit use the default format from the .conf file, and '1' as raw, then you could set it up so that applications have explicit control over all formats when desired, but can use the .conf file default

Re: [libvirt] [PATCH v3 4/4] add dump_memory_format in qemu.conf

2014-02-27 Thread Eric Blake
On 02/27/2014 07:55 AM, Daniel P. Berrange wrote: +else { +/* when --compress option is specified, qemu.conf will not work */ +cfg = virQEMUDriverGetConfig(driver); +if (cfg-dumpMemoryFormat) { +dump_memory_format =