Re: [libvirt] [PATCH v3 4/6] qemu: Implement period and quota tunable XML configuration and parsing

2011-07-19 Thread Adam Litke
On 07/18/2011 07:46 PM, Wen Congyang wrote: At 07/19/2011 04:35 AM, Adam Litke Write: This is looking good to me. I am pleased to see that the global case is handled as expected when per-vcpu threads are not active. On 07/18/2011 04:42 AM, Wen Congyang wrote: snip +int

Re: [libvirt] [PATCH v3 4/6] qemu: Implement period and quota tunable XML configuration and parsing

2011-07-19 Thread Adam Litke
On 07/18/2011 07:51 PM, Wen Congyang wrote: At 07/19/2011 04:59 AM, Adam Litke Write: On 07/18/2011 04:42 AM, Wen Congyang wrote: +int qemuSetupCgroupForVcpu(struct qemud_driver *driver, virDomainObjPtr vm) +{ +virCgroupPtr cgroup = NULL; +virCgroupPtr cgroup_vcpu = NULL; +

Re: [libvirt] [PATCH v3 4/6] qemu: Implement period and quota tunable XML configuration and parsing

2011-07-19 Thread Wen Congyang
At 07/19/2011 09:27 PM, Adam Litke Write: On 07/18/2011 07:51 PM, Wen Congyang wrote: At 07/19/2011 04:59 AM, Adam Litke Write: On 07/18/2011 04:42 AM, Wen Congyang wrote: +int qemuSetupCgroupForVcpu(struct qemud_driver *driver, virDomainObjPtr vm) +{ +virCgroupPtr cgroup = NULL;

[libvirt] [PATCH v3 4/6] qemu: Implement period and quota tunable XML configuration and parsing

2011-07-18 Thread Wen Congyang
--- src/conf/domain_conf.c | 20 +++- src/conf/domain_conf.h |2 + src/qemu/qemu_cgroup.c | 127 +++ src/qemu/qemu_cgroup.h |4 + src/qemu/qemu_process.c

Re: [libvirt] [PATCH v3 4/6] qemu: Implement period and quota tunable XML configuration and parsing

2011-07-18 Thread Adam Litke
On 07/18/2011 04:42 AM, Wen Congyang wrote: +int qemuSetupCgroupForVcpu(struct qemud_driver *driver, virDomainObjPtr vm) +{ +virCgroupPtr cgroup = NULL; +virCgroupPtr cgroup_vcpu = NULL; +qemuDomainObjPrivatePtr priv = vm-privateData; +int rc; +unsigned int i; +

Re: [libvirt] [PATCH v3 4/6] qemu: Implement period and quota tunable XML configuration and parsing

2011-07-18 Thread Wen Congyang
At 07/19/2011 04:35 AM, Adam Litke Write: This is looking good to me. I am pleased to see that the global case is handled as expected when per-vcpu threads are not active. On 07/18/2011 04:42 AM, Wen Congyang wrote: snip +int qemuSetupCgroupForVcpu(struct qemud_driver *driver,

Re: [libvirt] [PATCH v3 4/6] qemu: Implement period and quota tunable XML configuration and parsing

2011-07-18 Thread Wen Congyang
At 07/19/2011 04:59 AM, Adam Litke Write: On 07/18/2011 04:42 AM, Wen Congyang wrote: +int qemuSetupCgroupForVcpu(struct qemud_driver *driver, virDomainObjPtr vm) +{ +virCgroupPtr cgroup = NULL; +virCgroupPtr cgroup_vcpu = NULL; +qemuDomainObjPrivatePtr priv = vm-privateData;