Re: [libvirt] [PATCH v3 6/7] virsh: add function to get the CPU models for an arch

2013-09-16 Thread Daniel P. Berrange
On Fri, Sep 13, 2013 at 03:45:58PM -0600, Eric Blake wrote: > On 09/13/2013 03:06 PM, Eric Blake wrote: > > On 09/13/2013 02:58 PM, Eric Blake wrote: > >> On 09/11/2013 08:13 AM, Giuseppe Scrivano wrote: > >> > >> I tweaked this some during my testing of NULL models; but don't think we > >> need to

Re: [libvirt] [PATCH v3 6/7] virsh: add function to get the CPU models for an arch

2013-09-13 Thread Eric Blake
On 09/13/2013 03:06 PM, Eric Blake wrote: > On 09/13/2013 02:58 PM, Eric Blake wrote: >> On 09/11/2013 08:13 AM, Giuseppe Scrivano wrote: >> >> I tweaked this some during my testing of NULL models; but don't think we >> need to make virsh expose NULL models to the command line, so I'm not >> changi

Re: [libvirt] [PATCH v3 6/7] virsh: add function to get the CPU models for an arch

2013-09-13 Thread Eric Blake
On 09/11/2013 08:13 AM, Giuseppe Scrivano wrote: > Signed-off-by: Giuseppe Scrivano > --- > tools/virsh-host.c | 54 > ++ > tools/virsh.pod| 5 + > 2 files changed, 59 insertions(+) > + > +static const vshCmdOptDef opts_cpu_models[] =

Re: [libvirt] [PATCH v3 6/7] virsh: add function to get the CPU models for an arch

2013-09-13 Thread Eric Blake
On 09/13/2013 02:58 PM, Eric Blake wrote: > On 09/11/2013 08:13 AM, Giuseppe Scrivano wrote: > > I tweaked this some during my testing of NULL models; but don't think we > need to make virsh expose NULL models to the command line, so I'm not > changing this. > > ACK with this squashed in (oh, I j

Re: [libvirt] [PATCH v3 6/7] virsh: add function to get the CPU models for an arch

2013-09-13 Thread Eric Blake
On 09/11/2013 08:13 AM, Giuseppe Scrivano wrote: > Signed-off-by: Giuseppe Scrivano > --- > tools/virsh-host.c | 54 > ++ > tools/virsh.pod| 5 + > 2 files changed, 59 insertions(+) > > + > +static bool > +cmdCPUModelNames(vshControl

[libvirt] [PATCH v3 6/7] virsh: add function to get the CPU models for an arch

2013-09-11 Thread Giuseppe Scrivano
Signed-off-by: Giuseppe Scrivano --- tools/virsh-host.c | 54 ++ tools/virsh.pod| 5 + 2 files changed, 59 insertions(+) diff --git a/tools/virsh-host.c b/tools/virsh-host.c index 880ae4b..5d47428 100644 --- a/tools/virsh-host.c +++ b/