Re: [libvirt] [PATCH v3 REBASE 03/16] qemu: introduce QEMU_DOMAIN_JOB_STATUS_POSTCOPY

2017-08-30 Thread Nikolay Shirokovskiy
On 28.08.2017 17:55, Jiri Denemark wrote: > On Thu, Aug 24, 2017 at 09:56:40 +0300, Nikolay Shirokovskiy wrote: >> Current code consults job.current->stats.status to check for postcopy >> state. First it is more correct to check for both job.current->status >> and job.current->stats.status.code b

Re: [libvirt] [PATCH v3 REBASE 03/16] qemu: introduce QEMU_DOMAIN_JOB_STATUS_POSTCOPY

2017-08-28 Thread Jiri Denemark
On Thu, Aug 24, 2017 at 09:56:40 +0300, Nikolay Shirokovskiy wrote: > Current code consults job.current->stats.status to check for postcopy > state. First it is more correct to check for both job.current->status > and job.current->stats.status.code because on some paths on failures > we change only

[libvirt] [PATCH v3 REBASE 03/16] qemu: introduce QEMU_DOMAIN_JOB_STATUS_POSTCOPY

2017-08-24 Thread Nikolay Shirokovskiy
Current code consults job.current->stats.status to check for postcopy state. First it is more correct to check for both job.current->status and job.current->stats.status.code because on some paths on failures we change only the former. Second if qemu supports migration events then stats can change