Re: [libvirt] [PATCH v4] storage: netfs and iscsi need option srcSpec for resource discovery

2012-08-01 Thread Osier Yang
On 2012年07月31日 16:56, Guannan Ren wrote: The option 'srcSpec' to virsh command find-storage-pool-sources is optional for logical type of storage pool, but mandatory for netfs and iscsi type. When missing the option for netfs and iscsi, libvirt reports XML parsing error due to null string option

Re: [libvirt] [PATCH v4] storage: netfs and iscsi need option srcSpec for resource discovery

2012-08-01 Thread Guannan Ren
On 08/01/2012 10:51 PM, Osier Yang wrote: On 2012年07月31日 16:56, Guannan Ren wrote: diff --git a/tools/virsh-pool.c b/tools/virsh-pool.c index af80427..0f0b21e 100644 --- a/tools/virsh-pool.c +++ b/tools/virsh-pool.c @@ -1093,6 +1093,12 @@ cmdPoolDiscoverSources(vshControl * ctl, const vshCmd

[libvirt] [PATCH v4] storage: netfs and iscsi need option srcSpec for resource discovery

2012-07-31 Thread Guannan Ren
The option 'srcSpec' to virsh command find-storage-pool-sources is optional for logical type of storage pool, but mandatory for netfs and iscsi type. When missing the option for netfs and iscsi, libvirt reports XML parsing error due to null string option srcSpec. before error: Failed to find any