Re: [libvirt] [PATCH v4 00/26] scripts: convert most perl scripts to python

2019-10-17 Thread Erik Skultety
... > > FWIW, when I'm writing Go code I have used emacs 'go-mode' and > this runs 'go fmt' to automatically fix your style problems > every time you save the file. So your code is basically always > correct, and you don't need a separate job to check it later. Since you mentioned ^this, we

Re: [libvirt] [PATCH v4 00/26] scripts: convert most perl scripts to python

2019-10-10 Thread Daniel P . Berrangé
On Thu, Oct 10, 2019 at 03:28:39PM +0200, Ján Tomko wrote: > On Wed, Oct 09, 2019 at 12:37:15PM +0100, Daniel P. Berrangé wrote: > > Note that the check-spacing.py script is significantly > > slower in Python than in Perl. After researching this > > it appears there is nothing that can be done.

Re: [libvirt] [PATCH v4 00/26] scripts: convert most perl scripts to python

2019-10-10 Thread Ján Tomko
On Wed, Oct 09, 2019 at 12:37:15PM +0100, Daniel P. Berrangé wrote: Note that the check-spacing.py script is significantly slower in Python than in Perl. After researching this it appears there is nothing that can be done. The Perl regex engine is simply much better optimized than the Python

Re: [libvirt] [PATCH v4 00/26] scripts: convert most perl scripts to python

2019-10-10 Thread Daniel P . Berrangé
On Thu, Oct 10, 2019 at 09:22:29AM +0200, Andrea Bolognani wrote: > On Thu, 2019-10-10 at 08:55 +0200, Erik Skultety wrote: > > On Wed, Oct 09, 2019 at 02:01:37PM +0200, Peter Krempa wrote: > > > On Wed, Oct 09, 2019 at 12:37:15 +0100, Daniel Berrange wrote: > > > > Note that the check-spacing.py

Re: [libvirt] [PATCH v4 00/26] scripts: convert most perl scripts to python

2019-10-10 Thread Andrea Bolognani
On Thu, 2019-10-10 at 08:55 +0200, Erik Skultety wrote: > On Wed, Oct 09, 2019 at 02:01:37PM +0200, Peter Krempa wrote: > > On Wed, Oct 09, 2019 at 12:37:15 +0100, Daniel Berrange wrote: > > > Note that the check-spacing.py script is significantly > > > slower in Python than in Perl. After

Re: [libvirt] [PATCH v4 00/26] scripts: convert most perl scripts to python

2019-10-10 Thread Erik Skultety
On Wed, Oct 09, 2019 at 02:01:37PM +0200, Peter Krempa wrote: > On Wed, Oct 09, 2019 at 12:37:15 +0100, Daniel Berrange wrote: > > [...] > > > - src/rpc/gendispatch.pl > > - src/rpc/genprotocol.pl > > - tools/wireshark/util/genxdrstub.pl > > [...] > > > Note that the check-spacing.py script is

Re: [libvirt] [PATCH v4 00/26] scripts: convert most perl scripts to python

2019-10-09 Thread Peter Krempa
On Wed, Oct 09, 2019 at 12:37:15 +0100, Daniel Berrange wrote: [...] > - src/rpc/gendispatch.pl > - src/rpc/genprotocol.pl > - tools/wireshark/util/genxdrstub.pl [...] > Note that the check-spacing.py script is significantly > slower in Python than in Perl. After researching this > it

[libvirt] [PATCH v4 00/26] scripts: convert most perl scripts to python

2019-10-09 Thread Daniel P . Berrangé
This series is an effort to reduce the number of different languages we use by eliminating most use of perl in favour of python. This aligns with fact that the likely future build system we'll use (meson) is written in python, and that python is much more commonly used/understood by developers