Re: [libvirt] [PATCH v4 01/13] Adapt to VIR_STRDUP and VIR_STRNDUP in src/conf/*

2013-05-23 Thread Michal Privoznik
On 23.05.2013 15:56, John Ferlan wrote: > On 05/23/2013 09:44 AM, Michal Privoznik wrote: >> On 23.05.2013 15:04, John Ferlan wrote: >>> On 05/20/2013 01:55 PM, Michal Privoznik wrote: --- >>> [...snip...] >>> diff --git a/src/conf/nwfilter_params.c b/src/conf/nwfilter_params.c index

Re: [libvirt] [PATCH v4 01/13] Adapt to VIR_STRDUP and VIR_STRNDUP in src/conf/*

2013-05-23 Thread John Ferlan
On 05/23/2013 09:44 AM, Michal Privoznik wrote: > On 23.05.2013 15:04, John Ferlan wrote: >> On 05/20/2013 01:55 PM, Michal Privoznik wrote: >>> --- >> [...snip...] >> >>> diff --git a/src/conf/nwfilter_params.c b/src/conf/nwfilter_params.c >>> index 2509c0d..ac5f7ed 100644 >>> --- a/src/conf/nwfil

Re: [libvirt] [PATCH v4 01/13] Adapt to VIR_STRDUP and VIR_STRNDUP in src/conf/*

2013-05-23 Thread Michal Privoznik
On 23.05.2013 15:04, John Ferlan wrote: > On 05/20/2013 01:55 PM, Michal Privoznik wrote: >> --- > [...snip...] > >> diff --git a/src/conf/nwfilter_params.c b/src/conf/nwfilter_params.c >> index 2509c0d..ac5f7ed 100644 >> --- a/src/conf/nwfilter_params.c >> +++ b/src/conf/nwfilter_params.c >> @@ -

Re: [libvirt] [PATCH v4 01/13] Adapt to VIR_STRDUP and VIR_STRNDUP in src/conf/*

2013-05-23 Thread John Ferlan
On 05/20/2013 01:55 PM, Michal Privoznik wrote: > --- [...snip...] > diff --git a/src/conf/nwfilter_params.c b/src/conf/nwfilter_params.c > index 2509c0d..ac5f7ed 100644 > --- a/src/conf/nwfilter_params.c > +++ b/src/conf/nwfilter_params.c > @@ -79,19 +79,15 @@ virNWFilterVarValueCopy(const virNWF

Re: [libvirt] [PATCH v4 01/13] Adapt to VIR_STRDUP and VIR_STRNDUP in src/conf/*

2013-05-21 Thread Eric Blake
On 05/21/2013 03:14 AM, Michal Privoznik wrote: >>> @@ -392,17 +392,14 @@ virCapabilitiesAddGuest(virCapsPtr caps, >>> if (VIR_ALLOC(guest) < 0) >>> goto no_memory; >>> >>> -if ((guest->ostype = strdup(ostype)) == NULL) >>> +if (VIR_STRDUP(guest->ostype, ostype) < 0) >>>

Re: [libvirt] [PATCH v4 01/13] Adapt to VIR_STRDUP and VIR_STRNDUP in src/conf/*

2013-05-21 Thread Michal Privoznik
On 21.05.2013 00:38, Eric Blake wrote: > On 05/20/2013 11:55 AM, Michal Privoznik wrote: >> --- >> src/conf/capabilities.c | 30 --- >> src/conf/cpu_conf.c | 20 >> src/conf/domain_conf.c | 119 >> >> src/conf/domain

Re: [libvirt] [PATCH v4 01/13] Adapt to VIR_STRDUP and VIR_STRNDUP in src/conf/*

2013-05-20 Thread Eric Blake
On 05/20/2013 11:55 AM, Michal Privoznik wrote: > --- > src/conf/capabilities.c | 30 --- > src/conf/cpu_conf.c | 20 > src/conf/domain_conf.c | 119 > > src/conf/domain_event.c | 41 +++ > src/conf/

[libvirt] [PATCH v4 01/13] Adapt to VIR_STRDUP and VIR_STRNDUP in src/conf/*

2013-05-20 Thread Michal Privoznik
--- src/conf/capabilities.c | 30 --- src/conf/cpu_conf.c | 20 src/conf/domain_conf.c | 119 src/conf/domain_event.c | 41 +++ src/conf/node_device_conf.c | 28 +-- src/conf/nwfilter_conf.c