Re: [libvirt] [PATCH v4 02/17] Domain conf: allow more than one IP address for net devices

2014-12-11 Thread Daniel P. Berrange
On Thu, Dec 11, 2014 at 01:51:45PM -0500, Laine Stump wrote: > On 11/13/2014 04:33 AM, Cédric Bosdonnat wrote: > > @@ -4667,6 +4671,58 @@ virDomainHostdevDefParseXMLSubsys(xmlNodePtr node, > > return ret; > > } > > > > +static virDomainNetIpDefPtr > > +virDomainNetIpParseXML(xmlNodePtr node

Re: [libvirt] [PATCH v4 02/17] Domain conf: allow more than one IP address for net devices

2014-12-11 Thread Laine Stump
On 11/13/2014 04:33 AM, Cédric Bosdonnat wrote: > @@ -4667,6 +4671,58 @@ virDomainHostdevDefParseXMLSubsys(xmlNodePtr node, > return ret; > } > > +static virDomainNetIpDefPtr > +virDomainNetIpParseXML(xmlNodePtr node) > +{ > +/* Parse the prefix in every case */ > +virDomainNetIpDef

Re: [libvirt] [PATCH v4 02/17] Domain conf: allow more than one IP address for net devices

2014-12-02 Thread Dmitry Guryanov
On Thursday 13 November 2014 10:33:01 Cédric Bosdonnat wrote: > Add the possibility to have more than one IP address configured for a > domain network interface. IP addresses can also have a prefix to define > the corresponding netmask. I totally agree with this patch. IP configuration must be sep

[libvirt] [PATCH v4 02/17] Domain conf: allow more than one IP address for net devices

2014-11-13 Thread Cédric Bosdonnat
Add the possibility to have more than one IP address configured for a domain network interface. IP addresses can also have a prefix to define the corresponding netmask. --- docs/formatdomain.html.in | 22 docs/schemas/domaincommon.rng | 16 ++- src/co