Re: [libvirt] [PATCH v4 1/4] util: change the virStorageNetHostDef type

2016-12-14 Thread Prasanna Kalever
On Mon, Dec 12, 2016 at 8:00 PM, Peter Krempa wrote: > On Mon, Dec 12, 2016 at 19:54:47 +0530, Prasanna Kalever wrote: >> On Wed, Dec 7, 2016 at 7:31 PM, Peter Krempa wrote: >> > On Tue, Dec 06, 2016 at 22:51:58 +0530, Prasanna Kumar Kalever wrote: >> >>

Re: [libvirt] [PATCH v4 1/4] util: change the virStorageNetHostDef type

2016-12-12 Thread Peter Krempa
On Mon, Dec 12, 2016 at 19:54:47 +0530, Prasanna Kalever wrote: > On Wed, Dec 7, 2016 at 7:31 PM, Peter Krempa wrote: > > On Tue, Dec 06, 2016 at 22:51:58 +0530, Prasanna Kumar Kalever wrote: > >> Currently, the Host object looks like > >> > >> struct _virStorageNetHostDef { >

Re: [libvirt] [PATCH v4 1/4] util: change the virStorageNetHostDef type

2016-12-12 Thread Prasanna Kalever
On Wed, Dec 7, 2016 at 7:31 PM, Peter Krempa wrote: > On Tue, Dec 06, 2016 at 22:51:58 +0530, Prasanna Kumar Kalever wrote: >> Currently, the Host object looks like >> >> struct _virStorageNetHostDef { >> char *name; >> char *port; >> int transport; /*

Re: [libvirt] [PATCH v4 1/4] util: change the virStorageNetHostDef type

2016-12-07 Thread Peter Krempa
On Tue, Dec 06, 2016 at 22:51:58 +0530, Prasanna Kumar Kalever wrote: > Currently, the Host object looks like > > struct _virStorageNetHostDef { > char *name; > char *port; > int transport; /* virStorageNetHostTransport */ > char *socket; /* path to unix socket */

[libvirt] [PATCH v4 1/4] util: change the virStorageNetHostDef type

2016-12-06 Thread Prasanna Kumar Kalever
Currently, the Host object looks like struct _virStorageNetHostDef { char *name; char *port; int transport; /* virStorageNetHostTransport */ char *socket; /* path to unix socket */ } We don't actually need a 'name' and 'port' if the transport type is unix domain