Re: [libvirt] [PATCH v4 1/8] qemu_monitor: helper functions for CPU models

2019-08-20 Thread Jiri Denemark
On Wed, Jul 17, 2019 at 10:03:22 -0400, Collin Walling wrote: > Refactor some code in qemuMonitorJSONGetCPUModelExpansion to be > later used for the comparison and baseline functions. You're mixing refactoring with adding new functionality. Splitting such changes into separate patches is better.

Re: [libvirt] [PATCH v4 1/8] qemu_monitor: helper functions for CPU models

2019-07-25 Thread Collin Walling
Thanks for taking the time to review these! On 7/24/19 12:18 PM, Boris Fiuczynski wrote: Reviewed-by: Boris Fiuczynski On 7/17/19 4:03 PM, Collin Walling wrote: [...] -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v4 1/8] qemu_monitor: helper functions for CPU models

2019-07-24 Thread Boris Fiuczynski
Reviewed-by: Boris Fiuczynski On 7/17/19 4:03 PM, Collin Walling wrote: Refactor some code in qemuMonitorJSONGetCPUModelExpansion to be later used for the comparison and baseline functions. This does not alter any functionality. Signed-off-by: Collin Walling Reviewed-by: Bjoern Walk

[libvirt] [PATCH v4 1/8] qemu_monitor: helper functions for CPU models

2019-07-17 Thread Collin Walling
Refactor some code in qemuMonitorJSONGetCPUModelExpansion to be later used for the comparison and baseline functions. This does not alter any functionality. Signed-off-by: Collin Walling Reviewed-by: Bjoern Walk Reviewed-by: Daniel Henrique Barboza --- src/qemu/qemu_monitor_json.c | 173