Re: [libvirt] [PATCH v4 12/12] tests: add a test for driver.c:virConnectValidateURIPath()

2019-10-02 Thread Cole Robinson
On 9/27/19 5:32 PM, Daniel Henrique Barboza wrote: On 9/27/19 5:33 PM, Cole Robinson wrote: On 9/26/19 10:56 AM, Daniel Henrique Barboza wrote: Signed-off-by: Daniel Henrique Barboza --- I've made this test file to make sure I wasn't messing up with the logic at patch 8. The idea of having

Re: [libvirt] [PATCH v4 12/12] tests: add a test for driver.c:virConnectValidateURIPath()

2019-09-27 Thread Daniel Henrique Barboza
On 9/27/19 5:33 PM, Cole Robinson wrote: On 9/26/19 10:56 AM, Daniel Henrique Barboza wrote: Signed-off-by: Daniel Henrique Barboza --- I've made this test file to make sure I wasn't messing up with the logic at patch 8. The idea of having this test seems okay, but probably I could do it

Re: [libvirt] [PATCH v4 12/12] tests: add a test for driver.c:virConnectValidateURIPath()

2019-09-27 Thread Cole Robinson
On 9/26/19 10:56 AM, Daniel Henrique Barboza wrote: Signed-off-by: Daniel Henrique Barboza --- I've made this test file to make sure I wasn't messing up with the logic at patch 8. The idea of having this test seems okay, but probably I could do it shorter/cleaner. Feel free to discard it if

[libvirt] [PATCH v4 12/12] tests: add a test for driver.c:virConnectValidateURIPath()

2019-09-26 Thread Daniel Henrique Barboza
Signed-off-by: Daniel Henrique Barboza --- I've made this test file to make sure I wasn't messing up with the logic at patch 8. The idea of having this test seems okay, but probably I could do it shorter/cleaner. Feel free to discard it if it's not applicable or unnecessary. Adding this new