[libvirt] [PATCH v4 12/14] nodedev: Convert virNodeDeviceObj to use virObjectLockable

2017-07-03 Thread John Ferlan
Now that we have a bit more control, let's convert our object into a lockable object and let that magic handle the create and lock/unlock. This also involves creating a virNodeDeviceEndAPI in order to handle the object cleaup for API's that use the Add or Find API's in order to get a locked/reffed

Re: [libvirt] [PATCH v4 12/14] nodedev: Convert virNodeDeviceObj to use virObjectLockable

2017-07-10 Thread Erik Skultety
On Mon, Jul 03, 2017 at 05:25:28PM -0400, John Ferlan wrote: > Now that we have a bit more control, let's convert our object into > a lockable object and let that magic handle the create and lock/unlock. > > This also involves creating a virNodeDeviceEndAPI in order to handle > the object cleaup fo

Re: [libvirt] [PATCH v4 12/14] nodedev: Convert virNodeDeviceObj to use virObjectLockable

2017-07-10 Thread John Ferlan
On 07/10/2017 11:43 AM, Erik Skultety wrote: > On Mon, Jul 03, 2017 at 05:25:28PM -0400, John Ferlan wrote: >> Now that we have a bit more control, let's convert our object into >> a lockable object and let that magic handle the create and lock/unlock. >> >> This also involves creating a virNodeD

Re: [libvirt] [PATCH v4 12/14] nodedev: Convert virNodeDeviceObj to use virObjectLockable

2017-07-11 Thread Erik Skultety
On Mon, Jul 03, 2017 at 05:25:28PM -0400, John Ferlan wrote: > Now that we have a bit more control, let's convert our object into > a lockable object and let that magic handle the create and lock/unlock. > > This also involves creating a virNodeDeviceEndAPI in order to handle > the object cleaup fo

Re: [libvirt] [PATCH v4 12/14] nodedev: Convert virNodeDeviceObj to use virObjectLockable

2017-07-13 Thread John Ferlan
On 07/11/2017 10:38 AM, Erik Skultety wrote: > On Mon, Jul 03, 2017 at 05:25:28PM -0400, John Ferlan wrote: >> Now that we have a bit more control, let's convert our object into >> a lockable object and let that magic handle the create and lock/unlock. >> >> This also involves creating a virNodeD

Re: [libvirt] [PATCH v4 12/14] nodedev: Convert virNodeDeviceObj to use virObjectLockable

2017-07-14 Thread Erik Skultety
> >> cleanup: > >> -if (obj) > >> -virNodeDeviceObjUnlock(obj); > >> +virNodeDeviceObjEndAPI(&obj); > >> testDriverUnlock(driver); > >> virNodeDeviceDefFree(def); > >> virObjectUnref(dev); > >> @@ -5596,13 +5595,13 @@ testNodeDeviceDestroy(virNodeDevicePtr dev) > >>

Re: [libvirt] [PATCH v4 12/14] nodedev: Convert virNodeDeviceObj to use virObjectLockable

2017-07-14 Thread John Ferlan
On 07/14/2017 05:28 AM, Erik Skultety wrote: cleanup: -if (obj) -virNodeDeviceObjUnlock(obj); +virNodeDeviceObjEndAPI(&obj); testDriverUnlock(driver); virNodeDeviceDefFree(def); virObjectUnref(dev); @@ -5596,13 +5595,13 @@ t

Re: [libvirt] [PATCH v4 12/14] nodedev: Convert virNodeDeviceObj to use virObjectLockable

2017-07-16 Thread Erik Skultety
On Fri, Jul 14, 2017 at 10:12:12AM -0400, John Ferlan wrote: > > > On 07/14/2017 05:28 AM, Erik Skultety wrote: > cleanup: > -if (obj) > -virNodeDeviceObjUnlock(obj); > +virNodeDeviceObjEndAPI(&obj); > testDriverUnlock(driver); > virNodeDevi