Re: [libvirt] [PATCH v4 14/14] nodedev: Remove driver locks around object list mgmt code

2017-07-17 Thread Erik Skultety
On Fri, Jul 14, 2017 at 11:37:36AM -0400, John Ferlan wrote: > > > On 07/14/2017 05:23 AM, Erik Skultety wrote: > > On Thu, Jul 13, 2017 at 07:23:58PM -0400, John Ferlan wrote: > >> > >> > >> On 07/11/2017 10:38 AM, Erik Skultety wrote: > >>> On Mon, Jul 03, 2017 at 05:25:30PM -0400, John Ferlan

Re: [libvirt] [PATCH v4 14/14] nodedev: Remove driver locks around object list mgmt code

2017-07-14 Thread John Ferlan
On 07/14/2017 11:37 AM, John Ferlan wrote: > > > On 07/14/2017 05:23 AM, Erik Skultety wrote: >> On Thu, Jul 13, 2017 at 07:23:58PM -0400, John Ferlan wrote: >>> >>> >>> On 07/11/2017 10:38 AM, Erik Skultety wrote: On Mon, Jul 03, 2017 at 05:25:30PM -0400, John Ferlan wrote: > Since

Re: [libvirt] [PATCH v4 14/14] nodedev: Remove driver locks around object list mgmt code

2017-07-14 Thread John Ferlan
On 07/14/2017 05:23 AM, Erik Skultety wrote: > On Thu, Jul 13, 2017 at 07:23:58PM -0400, John Ferlan wrote: >> >> >> On 07/11/2017 10:38 AM, Erik Skultety wrote: >>> On Mon, Jul 03, 2017 at 05:25:30PM -0400, John Ferlan wrote: Since virnodedeviceobj now has a self-lockable hash table,

Re: [libvirt] [PATCH v4 14/14] nodedev: Remove driver locks around object list mgmt code

2017-07-14 Thread Erik Skultety
On Thu, Jul 13, 2017 at 07:23:58PM -0400, John Ferlan wrote: > > > On 07/11/2017 10:38 AM, Erik Skultety wrote: > > On Mon, Jul 03, 2017 at 05:25:30PM -0400, John Ferlan wrote: > >> Since virnodedeviceobj now has a self-lockable hash table, there's no > >> need to lock the table from the driver

Re: [libvirt] [PATCH v4 14/14] nodedev: Remove driver locks around object list mgmt code

2017-07-13 Thread John Ferlan
On 07/11/2017 10:38 AM, Erik Skultety wrote: > On Mon, Jul 03, 2017 at 05:25:30PM -0400, John Ferlan wrote: >> Since virnodedeviceobj now has a self-lockable hash table, there's no >> need to lock the table from the driver for processing. Thus remove the >> locks from the driver for

Re: [libvirt] [PATCH v4 14/14] nodedev: Remove driver locks around object list mgmt code

2017-07-13 Thread Erik Skultety
> /* Populate with known devices */ > This commentary should stay with the function it describes (below), so the context doesn't get lost. Erik > +nodeDeviceUnlock(); > if (udevEnumerateDevices(udev) != 0) > goto cleanup; > > -ret = 0; > +return 0; > > cleanup:

Re: [libvirt] [PATCH v4 14/14] nodedev: Remove driver locks around object list mgmt code

2017-07-11 Thread Erik Skultety
On Mon, Jul 03, 2017 at 05:25:30PM -0400, John Ferlan wrote: > Since virnodedeviceobj now has a self-lockable hash table, there's no > need to lock the table from the driver for processing. Thus remove the > locks from the driver for NodeDeviceObjList mgmt. > > Signed-off-by: John Ferlan

[libvirt] [PATCH v4 14/14] nodedev: Remove driver locks around object list mgmt code

2017-07-03 Thread John Ferlan
Since virnodedeviceobj now has a self-lockable hash table, there's no need to lock the table from the driver for processing. Thus remove the locks from the driver for NodeDeviceObjList mgmt. Signed-off-by: John Ferlan --- src/node_device/node_device_driver.c | 61