Re: [libvirt] [PATCH v4 3/6] libvirt-gconfig: Accept on/off as boolean attributes

2016-04-21 Thread Christophe Fergeau
On Fri, Apr 15, 2016 at 02:38:21PM +0100, Zeeshan Ali (Khattak) wrote: > gvir_config_object_get_attribute_boolean() currently only accepts yes/no > as boolean attribute values. Let's also accept on/off as valid values > too. As said in 4/6, I prefer to have the "on"/"off" check in the getter rathe

[libvirt] [PATCH v4 3/6] libvirt-gconfig: Accept on/off as boolean attributes

2016-04-15 Thread Zeeshan Ali (Khattak)
gvir_config_object_get_attribute_boolean() currently only accepts yes/no as boolean attribute values. Let's also accept on/off as valid values too. This will come handy in a following patch that adds 'hostdev' handling API. --- libvirt-gconfig/libvirt-gconfig-object.c | 4 ++-- 1 file changed, 2