Re: [libvirt] [PATCH v4 4/5] qmp: full introspection support for QMP

2014-01-28 Thread Amos Kong
On Mon, Jan 27, 2014 at 06:46:31PM +0800, Fam Zheng wrote: On Mon, 01/27 10:38, Paolo Bonzini wrote: Il 27/01/2014 09:17, Amos Kong ha scritto: CC Libvirt-list Original discussion: http://marc.info/?l=qemu-develm=139048842504757w=2 [Qemu-devel] [PATCH v4 0/5] QMP full

Re: [libvirt] [PATCH v4 4/5] qmp: full introspection support for QMP

2014-01-28 Thread Paolo Bonzini
Il 28/01/2014 11:45, Amos Kong ha scritto: My question is why is this generate-and-parse necessary? It's request of Libvirt, actually we can directly return the raw schema to Libvirt without extending/parsing, then Libvirt parse by itself. Can we achieve it with less duplication? Let's see

Re: [libvirt] [PATCH v4 4/5] qmp: full introspection support for QMP

2014-01-27 Thread Paolo Bonzini
Il 27/01/2014 09:17, Amos Kong ha scritto: CC Libvirt-list Original discussion: http://marc.info/?l=qemu-develm=139048842504757w=2 [Qemu-devel] [PATCH v4 0/5] QMP full introspection On Fri, Jan 24, 2014 at 06:48:31PM +0800, Fam Zheng wrote: On Thu, 01/23 22:46, Amos Kong wrote: This

Re: [libvirt] [PATCH v4 4/5] qmp: full introspection support for QMP

2014-01-27 Thread Amos Kong
On Mon, Jan 27, 2014 at 10:38:24AM +0100, Paolo Bonzini wrote: Il 27/01/2014 09:17, Amos Kong ha scritto: CC Libvirt-list Original discussion: http://marc.info/?l=qemu-develm=139048842504757w=2 [Qemu-devel] [PATCH v4 0/5] QMP full introspection On Fri, Jan 24, 2014 at 06:48:31PM

Re: [libvirt] [PATCH v4 4/5] qmp: full introspection support for QMP

2014-01-27 Thread Paolo Bonzini
Il 27/01/2014 11:07, Amos Kong ha scritto: No, I don't like this. QAPI types are perfectly able to describe themselves, there is no need to escape to JSON. Let's just do what this series is doing, minus the unnecessary recursion. The recursion extend was requested by Libvirt, they want

Re: [libvirt] [PATCH v4 4/5] qmp: full introspection support for QMP

2014-01-27 Thread Fam Zheng
On Mon, 01/27 10:38, Paolo Bonzini wrote: Il 27/01/2014 09:17, Amos Kong ha scritto: CC Libvirt-list Original discussion: http://marc.info/?l=qemu-develm=139048842504757w=2 [Qemu-devel] [PATCH v4 0/5] QMP full introspection On Fri, Jan 24, 2014 at 06:48:31PM +0800, Fam Zheng wrote: