Re: [libvirt] [PATCH v4 4/7] Add network events to the remote driver

2014-01-09 Thread Eric Blake
On 12/12/2013 07:30 AM, Cedric Bosdonnat wrote: Hi John, +event = virNetworkEventLifecycleNew(net-name, net-uuid, msg-event); +virNetworkFree(net); +remoteDomainEventQueue(priv, event); Essentially - you need to check for NULL event. Sure, but the weird thing it that it

Re: [libvirt] [PATCH v4 4/7] Add network events to the remote driver

2014-01-09 Thread Eric Blake
On 01/09/2014 07:50 PM, Eric Blake wrote: On 12/12/2013 07:30 AM, Cedric Bosdonnat wrote: Hi John, +event = virNetworkEventLifecycleNew(net-name, net-uuid, msg-event); +virNetworkFree(net); +remoteDomainEventQueue(priv, event); Essentially - you need to check for NULL event.

Re: [libvirt] [PATCH v4 4/7] Add network events to the remote driver

2013-12-12 Thread John Ferlan
My overnight Coverity run found an issue in the function: 'remoteNetworkBuildEventLifecycle' On 12/11/2013 05:38 AM, Cédric Bosdonnat wrote: --- daemon/libvirtd.h| 1 + daemon/remote.c | 139 +++ src/remote/remote_driver.c

Re: [libvirt] [PATCH v4 4/7] Add network events to the remote driver

2013-12-12 Thread Cedric Bosdonnat
Hi John, On Thu, 2013-12-12 at 06:50 -0500, John Ferlan wrote: 4920 (3) Event returned_null: Function virNetworkEventLifecycleNew(char const *, unsigned char const *, int) returns null (checked 10 out of 11 times). [details] (14) Event var_assigned: Assigning: event = null

[libvirt] [PATCH v4 4/7] Add network events to the remote driver

2013-12-11 Thread Cédric Bosdonnat
--- daemon/libvirtd.h| 1 + daemon/remote.c | 139 +++ src/remote/remote_driver.c | 127 +++ src/remote/remote_protocol.x | 46 +- 4 files changed, 312 insertions(+), 1

Re: [libvirt] [PATCH v4 4/7] Add network events to the remote driver

2013-12-11 Thread Daniel P. Berrange
On Wed, Dec 11, 2013 at 11:38:01AM +0100, Cédric Bosdonnat wrote: --- daemon/libvirtd.h| 1 + daemon/remote.c | 139 +++ src/remote/remote_driver.c | 127 +++

Re: [libvirt] [PATCH v4 4/7] Add network events to the remote driver

2013-12-11 Thread Daniel P. Berrange
On Wed, Dec 11, 2013 at 11:38:01AM +0100, Cédric Bosdonnat wrote: --- daemon/libvirtd.h| 1 + daemon/remote.c | 139 +++ src/remote/remote_driver.c | 127 +++