Re: [libvirt] [PATCH v4 4/9] Move iothreadspin information into iothreadids

2015-04-23 Thread John Ferlan
... + +if (!(iothrid = virDomainIOThreadIDFind(def, iothreadid))) { +if (!(iothrid = virDomainIOThreadIDAdd(def, iothreadid))) Why are you adding a iothread definition here? This code is executed after the iothread info should already be parsed so adding a thread here doesn't

Re: [libvirt] [PATCH v4 4/9] Move iothreadspin information into iothreadids

2015-04-23 Thread John Ferlan
On 04/23/2015 08:02 AM, Peter Krempa wrote: On Tue, Apr 21, 2015 at 19:31:25 -0400, John Ferlan wrote: Remove the iothreadspin array from cputune and replace with a cpumask to be stored in the iothreadids list Signed-off-by: John Ferlan jfer...@redhat.com --- docs/formatdomain.html.in |

Re: [libvirt] [PATCH v4 4/9] Move iothreadspin information into iothreadids

2015-04-23 Thread Peter Krempa
On Thu, Apr 23, 2015 at 08:58:26 -0400, John Ferlan wrote: On 04/23/2015 08:02 AM, Peter Krempa wrote: On Tue, Apr 21, 2015 at 19:31:25 -0400, John Ferlan wrote: Remove the iothreadspin array from cputune and replace with a cpumask to be stored in the iothreadids list Signed-off-by:

Re: [libvirt] [PATCH v4 4/9] Move iothreadspin information into iothreadids

2015-04-23 Thread Peter Krempa
On Tue, Apr 21, 2015 at 19:31:25 -0400, John Ferlan wrote: Remove the iothreadspin array from cputune and replace with a cpumask to be stored in the iothreadids list Signed-off-by: John Ferlan jfer...@redhat.com --- docs/formatdomain.html.in | 10 ++-- src/conf/domain_conf.c| 118

[libvirt] [PATCH v4 4/9] Move iothreadspin information into iothreadids

2015-04-21 Thread John Ferlan
Remove the iothreadspin array from cputune and replace with a cpumask to be stored in the iothreadids list Signed-off-by: John Ferlan jfer...@redhat.com --- docs/formatdomain.html.in | 10 ++-- src/conf/domain_conf.c| 118 +-