Re: [libvirt] [PATCH v4 5/5] on_missing: Emit event on disk source dropping

2011-10-21 Thread Daniel P. Berrange
On Fri, Oct 21, 2011 at 08:48:48AM +0200, Jiri Denemark wrote: > On Thu, Oct 20, 2011 at 16:32:55 +0100, Daniel P. Berrange wrote: > > On Thu, Oct 20, 2011 at 04:52:52PM +0200, Michal Privoznik wrote: > ... > > > +/** > > > + * virConnectDomainEventDiskEjectCallback: > > > + * @conn: connection obj

Re: [libvirt] [PATCH v4 5/5] on_missing: Emit event on disk source dropping

2011-10-20 Thread Jiri Denemark
On Thu, Oct 20, 2011 at 16:32:55 +0100, Daniel P. Berrange wrote: > On Thu, Oct 20, 2011 at 04:52:52PM +0200, Michal Privoznik wrote: ... > > +/** > > + * virConnectDomainEventDiskEjectCallback: > > + * @conn: connection object > > + * @dom: domain on which the event occurred > > + * @target: targe

Re: [libvirt] [PATCH v4 5/5] on_missing: Emit event on disk source dropping

2011-10-20 Thread Daniel P. Berrange
On Thu, Oct 20, 2011 at 04:52:52PM +0200, Michal Privoznik wrote: > If a disk source gets dropped because it is not accessible, > mgmt application might want to be informed about this. Therefore > we need to emit an event. The event presented in this patch > is however a bit superset of what writte

[libvirt] [PATCH v4 5/5] on_missing: Emit event on disk source dropping

2011-10-20 Thread Michal Privoznik
If a disk source gets dropped because it is not accessible, mgmt application might want to be informed about this. Therefore we need to emit an event. The event presented in this patch is however a bit superset of what written above. The reason is simple: an intention to be easily expanded, e.g. on