Re: [libvirt] [PATCH v4 8/8] qemu_driver: hook up query-cpu-model-comparison

2019-08-20 Thread Jiri Denemark
On Wed, Jul 17, 2019 at 10:03:29 -0400, Collin Walling wrote: > This command is hooked into the virsh hypervisor-cpu-compare command. > As such, the CPU model XML provided to the command will be compared > to the hypervisor CPU contained in the QEMU capabilities file for the > appropriate QEMU

Re: [libvirt] [PATCH v4 8/8] qemu_driver: hook up query-cpu-model-comparison

2019-07-26 Thread Boris Fiuczynski
On 7/25/19 8:26 PM, Collin Walling wrote: [...] + +virCPUCompareResult +virQEMUCapsCPUModelComparison(virQEMUCapsPtr qemuCaps, +  const char *libDir, +  uid_t runUid, +  gid_t runGid, +  

Re: [libvirt] [PATCH v4 8/8] qemu_driver: hook up query-cpu-model-comparison

2019-07-25 Thread Collin Walling
[...] + +virCPUCompareResult +virQEMUCapsCPUModelComparison(virQEMUCapsPtr qemuCaps, +  const char *libDir, +  uid_t runUid, +  gid_t runGid, +  virCPUDefPtr cpu_a, +  

Re: [libvirt] [PATCH v4 8/8] qemu_driver: hook up query-cpu-model-comparison

2019-07-24 Thread Boris Fiuczynski
Reviewed-by: Boris Fiuczynski On 7/17/19 4:03 PM, Collin Walling wrote: This command is hooked into the virsh hypervisor-cpu-compare command. As such, the CPU model XML provided to the command will be compared to the hypervisor CPU contained in the QEMU capabilities file for the appropriate

[libvirt] [PATCH v4 8/8] qemu_driver: hook up query-cpu-model-comparison

2019-07-17 Thread Collin Walling
This command is hooked into the virsh hypervisor-cpu-compare command. As such, the CPU model XML provided to the command will be compared to the hypervisor CPU contained in the QEMU capabilities file for the appropriate QEMU binary (for s390x, this CPU definition can be observed via virsh