Re: [libvirt] [PATCH v5 0/3] vsh: Introduce new API for printing tables

2018-08-28 Thread John Ferlan
On 08/28/2018 10:11 AM, Daniel P. Berrangé wrote: > On Tue, Aug 28, 2018 at 04:10:53PM +0200, Erik Skultety wrote: >> On Tue, Aug 28, 2018 at 03:52:56PM +0200, Ján Tomko wrote: >>> On Tue, Aug 28, 2018 at 02:46:08PM +0100, Daniel P. Berrangé wrote: On Tue, Aug 28, 2018 at 03:41:26PM +0200,

Re: [libvirt] [PATCH v5 0/3] vsh: Introduce new API for printing tables

2018-08-28 Thread Erik Skultety
On Tue, Aug 28, 2018 at 03:52:56PM +0200, Ján Tomko wrote: > On Tue, Aug 28, 2018 at 02:46:08PM +0100, Daniel P. Berrangé wrote: > > On Tue, Aug 28, 2018 at 03:41:26PM +0200, Ján Tomko wrote: > > > On Tue, Aug 28, 2018 at 02:24:19PM +0100, Daniel P. Berrangé wrote: > > > > On Tue, Aug 28, 2018 at

Re: [libvirt] [PATCH v5 0/3] vsh: Introduce new API for printing tables

2018-08-28 Thread Ján Tomko
On Tue, Aug 28, 2018 at 02:46:08PM +0100, Daniel P. Berrangé wrote: On Tue, Aug 28, 2018 at 03:41:26PM +0200, Ján Tomko wrote: On Tue, Aug 28, 2018 at 02:24:19PM +0100, Daniel P. Berrangé wrote: > On Tue, Aug 28, 2018 at 02:24:42PM +0200, Ján Tomko wrote: > > On Tue, Aug 28, 2018 at 02:10:55PM

Re: [libvirt] [PATCH v5 0/3] vsh: Introduce new API for printing tables

2018-08-28 Thread Daniel P . Berrangé
On Tue, Aug 28, 2018 at 03:41:26PM +0200, Ján Tomko wrote: > On Tue, Aug 28, 2018 at 02:24:19PM +0100, Daniel P. Berrangé wrote: > > On Tue, Aug 28, 2018 at 02:24:42PM +0200, Ján Tomko wrote: > > > On Tue, Aug 28, 2018 at 02:10:55PM +0200, Erik Skultety wrote: > > > > > So how about storing 2 sets

Re: [libvirt] [PATCH v5 0/3] vsh: Introduce new API for printing tables

2018-08-28 Thread Ján Tomko
On Tue, Aug 28, 2018 at 02:24:19PM +0100, Daniel P. Berrangé wrote: On Tue, Aug 28, 2018 at 02:24:42PM +0200, Ján Tomko wrote: On Tue, Aug 28, 2018 at 02:10:55PM +0200, Erik Skultety wrote: > > So how about storing 2 sets of expected data for this test case. > > Two is not enough. My clang

Re: [libvirt] [PATCH v5 0/3] vsh: Introduce new API for printing tables

2018-08-28 Thread Daniel P . Berrangé
On Tue, Aug 28, 2018 at 02:24:42PM +0200, Ján Tomko wrote: > On Tue, Aug 28, 2018 at 02:10:55PM +0200, Erik Skultety wrote: > > On Tue, Aug 28, 2018 at 11:35:02AM +0100, Daniel P. Berrangé wrote: > > > On Mon, Aug 27, 2018 at 05:50:22PM +0200, Simon Kobyda wrote: > > > > On Fri, 2018-08-24 at

Re: [libvirt] [PATCH v5 0/3] vsh: Introduce new API for printing tables

2018-08-28 Thread Daniel P . Berrangé
On Tue, Aug 28, 2018 at 02:10:55PM +0200, Erik Skultety wrote: > On Tue, Aug 28, 2018 at 11:35:02AM +0100, Daniel P. Berrangé wrote: > > On Mon, Aug 27, 2018 at 05:50:22PM +0200, Simon Kobyda wrote: > > > On Fri, 2018-08-24 at 12:10 +0200, Michal Privoznik wrote: > > > > On 08/24/2018 11:36 AM,

Re: [libvirt] [PATCH v5 0/3] vsh: Introduce new API for printing tables

2018-08-28 Thread Simon Kobyda
On Tue, 2018-08-28 at 14:35 +0200, Simon Kobyda wrote: > CentOS 7 uses > glibc 2.17, which was released in December 2017 Sorry made a typo there, glibc 2.17 was released in 2012 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v5 0/3] vsh: Introduce new API for printing tables

2018-08-28 Thread Simon Kobyda
On Fri, 2018-08-24 at 11:18 +0100, Daniel P. Berrangé wrote: > On Fri, Aug 24, 2018 at 12:10:47PM +0200, Michal Privoznik wrote: > > On 08/24/2018 11:36 AM, Daniel P. Berrangé wrote: > > > On Fri, Aug 24, 2018 at 10:59:04AM +0200, Michal Privoznik wrote: > > > > On 08/23/2018 05:53 PM, Simon

Re: [libvirt] [PATCH v5 0/3] vsh: Introduce new API for printing tables

2018-08-28 Thread Ján Tomko
On Tue, Aug 28, 2018 at 02:30:23PM +0200, Erik Skultety wrote: On Tue, Aug 28, 2018 at 02:24:42PM +0200, Ján Tomko wrote: I still see a benefit in having testUnicodeBasic that passes everywhere (does it?), and conditionally running the monkey test on platforms where iswprint returns the proper

Re: [libvirt] [PATCH v5 0/3] vsh: Introduce new API for printing tables

2018-08-28 Thread Erik Skultety
On Tue, Aug 28, 2018 at 02:24:42PM +0200, Ján Tomko wrote: > On Tue, Aug 28, 2018 at 02:10:55PM +0200, Erik Skultety wrote: > > On Tue, Aug 28, 2018 at 11:35:02AM +0100, Daniel P. Berrangé wrote: > > > On Mon, Aug 27, 2018 at 05:50:22PM +0200, Simon Kobyda wrote: > > > > On Fri, 2018-08-24 at

Re: [libvirt] [PATCH v5 0/3] vsh: Introduce new API for printing tables

2018-08-28 Thread Ján Tomko
On Tue, Aug 28, 2018 at 02:10:55PM +0200, Erik Skultety wrote: On Tue, Aug 28, 2018 at 11:35:02AM +0100, Daniel P. Berrangé wrote: On Mon, Aug 27, 2018 at 05:50:22PM +0200, Simon Kobyda wrote: > On Fri, 2018-08-24 at 12:10 +0200, Michal Privoznik wrote: > > On 08/24/2018 11:36 AM, Daniel P.

Re: [libvirt] [PATCH v5 0/3] vsh: Introduce new API for printing tables

2018-08-28 Thread Erik Skultety
On Tue, Aug 28, 2018 at 11:35:02AM +0100, Daniel P. Berrangé wrote: > On Mon, Aug 27, 2018 at 05:50:22PM +0200, Simon Kobyda wrote: > > On Fri, 2018-08-24 at 12:10 +0200, Michal Privoznik wrote: > > > On 08/24/2018 11:36 AM, Daniel P. Berrangé wrote: > > > > On Fri, Aug 24, 2018 at 10:59:04AM

Re: [libvirt] [PATCH v5 0/3] vsh: Introduce new API for printing tables

2018-08-28 Thread Daniel P . Berrangé
On Mon, Aug 27, 2018 at 05:50:22PM +0200, Simon Kobyda wrote: > On Fri, 2018-08-24 at 12:10 +0200, Michal Privoznik wrote: > > On 08/24/2018 11:36 AM, Daniel P. Berrangé wrote: > > > On Fri, Aug 24, 2018 at 10:59:04AM +0200, Michal Privoznik wrote: > > > > > > But first fix the build failures :-)

Re: [libvirt] [PATCH v5 0/3] vsh: Introduce new API for printing tables

2018-08-27 Thread Simon Kobyda
On Fri, 2018-08-24 at 12:10 +0200, Michal Privoznik wrote: > On 08/24/2018 11:36 AM, Daniel P. Berrangé wrote: > > On Fri, Aug 24, 2018 at 10:59:04AM +0200, Michal Privoznik wrote: > > > > But first fix the build failures :-) > > > > On CentOS / RHEL: > > > >

Re: [libvirt] [PATCH v5 0/3] vsh: Introduce new API for printing tables

2018-08-24 Thread Daniel P . Berrangé
On Fri, Aug 24, 2018 at 12:10:47PM +0200, Michal Privoznik wrote: > On 08/24/2018 11:36 AM, Daniel P. Berrangé wrote: > > On Fri, Aug 24, 2018 at 10:59:04AM +0200, Michal Privoznik wrote: > >> On 08/23/2018 05:53 PM, Simon Kobyda wrote: > >>> Created new API for priting tables, mainly to solve

Re: [libvirt] [PATCH v5 0/3] vsh: Introduce new API for printing tables

2018-08-24 Thread Michal Privoznik
On 08/24/2018 11:36 AM, Daniel P. Berrangé wrote: > On Fri, Aug 24, 2018 at 10:59:04AM +0200, Michal Privoznik wrote: >> On 08/23/2018 05:53 PM, Simon Kobyda wrote: >>> Created new API for priting tables, mainly to solve alignment problems. >>> Implemented these test to virsh list. In the future,

Re: [libvirt] [PATCH v5 0/3] vsh: Introduce new API for printing tables

2018-08-24 Thread Daniel P . Berrangé
On Fri, Aug 24, 2018 at 10:59:04AM +0200, Michal Privoznik wrote: > On 08/23/2018 05:53 PM, Simon Kobyda wrote: > > Created new API for priting tables, mainly to solve alignment problems. > > Implemented these test to virsh list. In the future, API may be > > everywhere in virsh and virt-admin. >

Re: [libvirt] [PATCH v5 0/3] vsh: Introduce new API for printing tables

2018-08-24 Thread Michal Privoznik
On 08/23/2018 05:53 PM, Simon Kobyda wrote: > Created new API for priting tables, mainly to solve alignment problems. > Implemented these test to virsh list. In the future, API may be > everywhere in virsh and virt-admin. > Also wrote basic tests for the new API, and corrected tests in virshtest >

[libvirt] [PATCH v5 0/3] vsh: Introduce new API for printing tables

2018-08-23 Thread Simon Kobyda
Created new API for priting tables, mainly to solve alignment problems. Implemented these test to virsh list. In the future, API may be everywhere in virsh and virt-admin. Also wrote basic tests for the new API, and corrected tests in virshtest which are influenced by implementation of the API in