Re: [libvirt] [PATCH v5 0/4] qemu: Allow PCI virtio on ARM virt machine

2015-08-12 Thread Pavel Fedin
Hello! I was a bit confused about the patches that landed; I see now that they only add a PCI controller for modern -M virt, but don't change the virtio defaults to use it. Yes, because in first versions i changed the default and was criticized for it, because it broke backwards

Re: [libvirt] [PATCH v5 0/4] qemu: Allow PCI virtio on ARM virt machine

2015-08-11 Thread Laine Stump
(Alex - I cc'ed you because I addressed a question or two your way down towards the bottom). On 08/11/2015 02:52 AM, Pavel Fedin wrote: Hello! The original patches to support pcie-root severely restricted what could plug into what because in real hardware you can't plug a PCI device into a

Re: [libvirt] [PATCH v5 0/4] qemu: Allow PCI virtio on ARM virt machine

2015-08-11 Thread Pavel Fedin
Hello! The original patches to support pcie-root severely restricted what could plug into what because in real hardware you can't plug a PCI device into a PCIe slot (physically it doesn't work) But how do you know whether the device is PCI or PCIe ? I don't see anything like this in the

Re: [libvirt] [PATCH v5 0/4] qemu: Allow PCI virtio on ARM virt machine

2015-08-11 Thread Cole Robinson
On 07/17/2015 07:27 AM, Pavel Fedin wrote: Virt machine in qemu since v2.3.0 has PCI generic host controller, and can use PCI devices. This provides performance improvement as well as vhost-net with irqfd support for virtio-net. However libvirt currently does not allow ARM virt machine to have

Re: [libvirt] [PATCH v5 0/4] qemu: Allow PCI virtio on ARM virt machine

2015-08-11 Thread Laine Stump
On 08/11/2015 01:51 PM, Cole Robinson wrote: On 07/17/2015 07:27 AM, Pavel Fedin wrote: Virt machine in qemu since v2.3.0 has PCI generic host controller, and can use PCI devices. This provides performance improvement as well as vhost-net with irqfd support for virtio-net. However libvirt

Re: [libvirt] [PATCH v5 0/4] qemu: Allow PCI virtio on ARM virt machine

2015-08-11 Thread Alex Williamson
On Tue, 2015-08-11 at 19:26 -0400, Laine Stump wrote: (Alex - I cc'ed you because I addressed a question or two your way down towards the bottom). On 08/11/2015 02:52 AM, Pavel Fedin wrote: Hello! The original patches to support pcie-root severely restricted what could plug into what

Re: [libvirt] [PATCH v5 0/4] qemu: Allow PCI virtio on ARM virt machine

2015-08-11 Thread Laine Stump
On 08/11/2015 10:13 PM, Alex Williamson wrote: On Tue, 2015-08-11 at 19:26 -0400, Laine Stump wrote: (Alex - I cc'ed you because I addressed a question or two your way down towards the bottom). On 08/11/2015 02:52 AM, Pavel Fedin wrote: Hello! The original patches to support pcie-root

Re: [libvirt] [PATCH v5 0/4] qemu: Allow PCI virtio on ARM virt machine

2015-08-10 Thread Laine Stump
On 08/06/2015 09:38 AM, Michal Privoznik wrote: On 06.08.2015 15:06, Pavel Fedin wrote: Hello! ACKed all the patches, squashed in the 2/4 amendment and pushed. Sorry for the delay. Thank you very much. By the way, just curious, why is there a restriction to plug in most of devices

Re: [libvirt] [PATCH v5 0/4] qemu: Allow PCI virtio on ARM virt machine

2015-08-06 Thread Pavel Fedin
Yeah, that's a good question. In a real world, PCIe is perfectly hot pluggable. Maybe the limitation comes from qemu? OTOH, why do we require devices to be hotpluggable ? Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -- libvir-list mailing list

Re: [libvirt] [PATCH v5 0/4] qemu: Allow PCI virtio on ARM virt machine

2015-08-06 Thread Michal Privoznik
On 17.07.2015 13:27, Pavel Fedin wrote: Virt machine in qemu since v2.3.0 has PCI generic host controller, and can use PCI devices. This provides performance improvement as well as vhost-net with irqfd support for virtio-net. However libvirt currently does not allow ARM virt machine to have

Re: [libvirt] [PATCH v5 0/4] qemu: Allow PCI virtio on ARM virt machine

2015-08-06 Thread Pavel Fedin
Hello! ACKed all the patches, squashed in the 2/4 amendment and pushed. Sorry for the delay. Thank you very much. By the way, just curious, why is there a restriction to plug in most of devices only into PCI, not PCIe? On machines with PCIe host this seems to do nothing good, only

Re: [libvirt] [PATCH v5 0/4] qemu: Allow PCI virtio on ARM virt machine

2015-08-06 Thread Michal Privoznik
On 06.08.2015 15:06, Pavel Fedin wrote: Hello! ACKed all the patches, squashed in the 2/4 amendment and pushed. Sorry for the delay. Thank you very much. By the way, just curious, why is there a restriction to plug in most of devices only into PCI, not PCIe? On machines with PCIe

[libvirt] [PATCH v5 0/4] qemu: Allow PCI virtio on ARM virt machine

2015-07-17 Thread Pavel Fedin
Virt machine in qemu since v2.3.0 has PCI generic host controller, and can use PCI devices. This provides performance improvement as well as vhost-net with irqfd support for virtio-net. However libvirt currently does not allow ARM virt machine to have PCI devices. This patchset adds the necessary