Re: [libvirt] [PATCH v5 01/24] conf: allow bandwidth parsing / formatting to include class ID

2019-05-20 Thread Daniel P . Berrangé
On Sun, May 19, 2019 at 06:16:54PM -0400, Laine Stump wrote: > On 5/14/19 11:48 AM, Daniel P. Berrangé wrote: > > The domain conf actual network def stores a element > > separately from the . The class ID should really just be > > an attribute on the element. We can't change existing > > XML,

Re: [libvirt] [PATCH v5 01/24] conf: allow bandwidth parsing / formatting to include class ID

2019-05-19 Thread Laine Stump
On 5/14/19 11:48 AM, Daniel P. Berrangé wrote: The domain conf actual network def stores a element separately from the . The class ID should really just be an attribute on the element. We can't change existing XML, and this isn't visible to users since it is internal XML only. When we expose

[libvirt] [PATCH v5 01/24] conf: allow bandwidth parsing / formatting to include class ID

2019-05-14 Thread Daniel P . Berrangé
The domain conf actual network def stores a element separately from the . The class ID should really just be an attribute on the element. We can't change existing XML, and this isn't visible to users since it is internal XML only. When we expose the new network port XML to users though, we