Re: [libvirt] [PATCH v5 02/16] qemu: Introduce qemuDomainDeviceDefValidateControllerAttributes

2018-01-30 Thread John Ferlan
[...] >>> Ideally a prerequisite. If that's too much yak shaving for you, >>> at least add a comment to the validate function saying picking a default >>> model really does not belong in a validation function. > > Well it really should not be there. I've tried to make sure that at > least the

Re: [libvirt] [PATCH v5 02/16] qemu: Introduce qemuDomainDeviceDefValidateControllerAttributes

2018-01-30 Thread Peter Krempa
On Mon, Jan 29, 2018 at 16:18:46 -0500, John Ferlan wrote: > > > On 01/29/2018 12:53 PM, Ján Tomko wrote: > > On Mon, Jan 29, 2018 at 12:43:14PM -0500, John Ferlan wrote: > >> > >> > >> On 01/29/2018 04:18 AM, Ján Tomko wrote: > >>> On Fri, Jan 05, 2018 at 06:47:25PM -0500, John Ferlan wrote: >

Re: [libvirt] [PATCH v5 02/16] qemu: Introduce qemuDomainDeviceDefValidateControllerAttributes

2018-01-29 Thread John Ferlan
On 01/29/2018 12:53 PM, Ján Tomko wrote: > On Mon, Jan 29, 2018 at 12:43:14PM -0500, John Ferlan wrote: >> >> >> On 01/29/2018 04:18 AM, Ján Tomko wrote: >>> On Fri, Jan 05, 2018 at 06:47:25PM -0500, John Ferlan wrote: Move the checks that various attributes are not set on any controller

Re: [libvirt] [PATCH v5 02/16] qemu: Introduce qemuDomainDeviceDefValidateControllerAttributes

2018-01-29 Thread Ján Tomko
On Mon, Jan 29, 2018 at 12:43:14PM -0500, John Ferlan wrote: On 01/29/2018 04:18 AM, Ján Tomko wrote: On Fri, Jan 05, 2018 at 06:47:25PM -0500, John Ferlan wrote: Move the checks that various attributes are not set on any controller other than SCSI controller using virtio-scsi model into the

Re: [libvirt] [PATCH v5 02/16] qemu: Introduce qemuDomainDeviceDefValidateControllerAttributes

2018-01-29 Thread John Ferlan
On 01/29/2018 04:18 AM, Ján Tomko wrote: > On Fri, Jan 05, 2018 at 06:47:25PM -0500, John Ferlan wrote: >> Move the checks that various attributes are not set on any controller >> other than SCSI controller using virtio-scsi model into the common >> controller validate checks. >> >> Need to also

Re: [libvirt] [PATCH v5 02/16] qemu: Introduce qemuDomainDeviceDefValidateControllerAttributes

2018-01-29 Thread John Ferlan
On 01/29/2018 04:28 AM, Ján Tomko wrote: > On Sun, Jan 28, 2018 at 09:48:19AM +0100, Michal Privoznik wrote: >> On 01/06/2018 12:47 AM, John Ferlan wrote: >>> Move the checks that various attributes are not set on any controller >>> other than SCSI controller using virtio-scsi model into the

Re: [libvirt] [PATCH v5 02/16] qemu: Introduce qemuDomainDeviceDefValidateControllerAttributes

2018-01-29 Thread Ján Tomko
On Sun, Jan 28, 2018 at 09:48:19AM +0100, Michal Privoznik wrote: On 01/06/2018 12:47 AM, John Ferlan wrote: Move the checks that various attributes are not set on any controller other than SCSI controller using virtio-scsi model into the common controller validate checks. Need to also add a

Re: [libvirt] [PATCH v5 02/16] qemu: Introduce qemuDomainDeviceDefValidateControllerAttributes

2018-01-29 Thread Ján Tomko
On Fri, Jan 05, 2018 at 06:47:25PM -0500, John Ferlan wrote: Move the checks that various attributes are not set on any controller other than SCSI controller using virtio-scsi model into the common controller validate checks. Need to also add a qemuDomainResetSCSIControllerModel call in order

Re: [libvirt] [PATCH v5 02/16] qemu: Introduce qemuDomainDeviceDefValidateControllerAttributes

2018-01-28 Thread Michal Privoznik
On 01/06/2018 12:47 AM, John Ferlan wrote: > Move the checks that various attributes are not set on any controller > other than SCSI controller using virtio-scsi model into the common > controller validate checks. > > Need to also add a qemuDomainResetSCSIControllerModel call in order > to ensure

[libvirt] [PATCH v5 02/16] qemu: Introduce qemuDomainDeviceDefValidateControllerAttributes

2018-01-05 Thread John Ferlan
Move the checks that various attributes are not set on any controller other than SCSI controller using virtio-scsi model into the common controller validate checks. Need to also add a qemuDomainResetSCSIControllerModel call in order to ensure we get the "right" SCSI model if it's not set by