Re: [libvirt] [PATCH v5 03/10] conf: introduce launch-security element in domain

2018-04-04 Thread John Ferlan
[...] >> >> Hopefully hexuint will suffice over time... On the other hand, this >> patch uses virXPathULongHex in order to parse. >> > > IIRC, I was not able to find anything other than hexuint in > basictypes.rng and also was not able to a function like > virXPathUIntHex(..). If you can point

Re: [libvirt] [PATCH v5 03/10] conf: introduce launch-security element in domain

2018-04-03 Thread Erik Skultety
... > > > > typedef enum { > > +VIR_DOMAIN_LAUNCH_SECURITY_NONE, > > +VIR_DOMAIN_LAUNCH_SECURITY_SEV, > > + > > +VIR_DOMAIN_LAUNCH_SECURITY_LAST, > > +} virDomainLaunchSecurity; > > + > > +typedef struct _virDomainSevDef virDomainSevDef; > > +typedef virDomainSevDef

Re: [libvirt] [PATCH v5 03/10] conf: introduce launch-security element in domain

2018-04-02 Thread Brijesh Singh
Hi John, Thanks for very details review feedbacks. On 04/02/2018 01:26 PM, John Ferlan wrote: On 04/02/2018 10:18 AM, Brijesh Singh wrote: The launch-security element can be used to define the security model to use when launching a domain. Currently we support 'sev'. When 'sev' is used,

Re: [libvirt] [PATCH v5 03/10] conf: introduce launch-security element in domain

2018-04-02 Thread John Ferlan
On 04/02/2018 10:18 AM, Brijesh Singh wrote: > The launch-security element can be used to define the security > model to use when launching a domain. Currently we support 'sev'. > > When 'sev' is used, the VM will be launched with AMD SEV feature enabled. > SEV feature supports running

Re: [libvirt] [PATCH v5 03/10] conf: introduce launch-security element in domain

2018-04-02 Thread John Ferlan
On 04/02/2018 10:18 AM, Brijesh Singh wrote: > The launch-security element can be used to define the security > model to use when launching a domain. Currently we support 'sev'. > > When 'sev' is used, the VM will be launched with AMD SEV feature enabled. > SEV feature supports running

[libvirt] [PATCH v5 03/10] conf: introduce launch-security element in domain

2018-04-02 Thread Brijesh Singh
The launch-security element can be used to define the security model to use when launching a domain. Currently we support 'sev'. When 'sev' is used, the VM will be launched with AMD SEV feature enabled. SEV feature supports running encrypted VM under the control of KVM. Encrypted VMs have their