Re: [libvirt] [PATCH v5 1/3] add new virDomainCoreDumpWithFormat API

2014-03-17 Thread Daniel P. Berrange
On Thu, Mar 13, 2014 at 08:42:40AM +0100, Martin Kletzander wrote: On Wed, Mar 12, 2014 at 09:29:55AM -0600, Eric Blake wrote: On 03/12/2014 09:04 AM, Martin Kletzander wrote: On Thu, Mar 06, 2014 at 09:35:47AM +, qiaonuo...@cn.fujitsu.com wrote: --memory-only option is introduced

Re: [libvirt] [PATCH v5 1/3] add new virDomainCoreDumpWithFormat API

2014-03-17 Thread Martin Kletzander
On Mon, Mar 17, 2014 at 09:37:46AM +, Daniel P. Berrange wrote: On Thu, Mar 13, 2014 at 08:42:40AM +0100, Martin Kletzander wrote: On Wed, Mar 12, 2014 at 09:29:55AM -0600, Eric Blake wrote: On 03/12/2014 09:04 AM, Martin Kletzander wrote: On Thu, Mar 06, 2014 at 09:35:47AM +,

Re: [libvirt] [PATCH v5 1/3] add new virDomainCoreDumpWithFormat API

2014-03-16 Thread qiaonuo...@cn.fujitsu.com
On 03/13/2014 03:42 PM, Martin Kletzander wrote: On Wed, Mar 12, 2014 at 09:29:55AM -0600, Eric Blake wrote: On 03/12/2014 09:04 AM, Martin Kletzander wrote: On Thu, Mar 06, 2014 at 09:35:47AM +,qiaonuo...@cn.fujitsu.com wrote: --memory-only option is introduced without

Re: [libvirt] [PATCH v5 1/3] add new virDomainCoreDumpWithFormat API

2014-03-13 Thread Martin Kletzander
On Wed, Mar 12, 2014 at 09:29:55AM -0600, Eric Blake wrote: On 03/12/2014 09:04 AM, Martin Kletzander wrote: On Thu, Mar 06, 2014 at 09:35:47AM +, qiaonuo...@cn.fujitsu.com wrote: --memory-only option is introduced without compression supported. Therefore, this is a freature

Re: [libvirt] [PATCH v5 1/3] add new virDomainCoreDumpWithFormat API

2014-03-13 Thread qiaonuo...@cn.fujitsu.com
On 03/12/2014 11:04 PM, Martin Kletzander wrote: diff --git c/src/test/test_driver.c i/src/test/test_driver.c index 39b3066..20f7bb3 100644 --- c/src/test/test_driver.c +++ i/src/test/test_driver.c @@ -2436,6 +2436,13 @@ static int testDomainCoreDumpWithFormat(virDomainPtr domain,

Re: [libvirt] [PATCH v5 1/3] add new virDomainCoreDumpWithFormat API

2014-03-13 Thread qiaonuo...@cn.fujitsu.com
On 03/13/2014 03:42 PM, Martin Kletzander wrote: On Wed, Mar 12, 2014 at 09:29:55AM -0600, Eric Blake wrote: On 03/12/2014 09:04 AM, Martin Kletzander wrote: On Thu, Mar 06, 2014 at 09:35:47AM +, qiaonuo...@cn.fujitsu.com wrote: --memory-only option is introduced without compression

Re: [libvirt] [PATCH v5 1/3] add new virDomainCoreDumpWithFormat API

2014-03-13 Thread Martin Kletzander
On Thu, Mar 13, 2014 at 09:20:09AM +, qiaonuo...@cn.fujitsu.com wrote: On 03/12/2014 11:04 PM, Martin Kletzander wrote: diff --git c/src/test/test_driver.c i/src/test/test_driver.c index 39b3066..20f7bb3 100644 --- c/src/test/test_driver.c +++ i/src/test/test_driver.c @@ -2436,6

Re: [libvirt] [PATCH v5 1/3] add new virDomainCoreDumpWithFormat API

2014-03-12 Thread Martin Kletzander
On Thu, Mar 06, 2014 at 09:35:47AM +, qiaonuo...@cn.fujitsu.com wrote: --memory-only option is introduced without compression supported. Therefore, this is a freature regression of virsh dump. Now qemu has support dumping memory s/freature/feature/ but I would not use the word regression

Re: [libvirt] [PATCH v5 1/3] add new virDomainCoreDumpWithFormat API

2014-03-12 Thread Eric Blake
On 03/12/2014 09:04 AM, Martin Kletzander wrote: On Thu, Mar 06, 2014 at 09:35:47AM +, qiaonuo...@cn.fujitsu.com wrote: --memory-only option is introduced without compression supported. Therefore, this is a freature regression of virsh dump. Now qemu has support dumping memory

Re: [libvirt] [PATCH v5 1/3] add new virDomainCoreDumpWithFormat API

2014-03-12 Thread Daniel P. Berrange
On Thu, Mar 06, 2014 at 09:35:47AM +, qiaonuo...@cn.fujitsu.com wrote: --memory-only option is introduced without compression supported. Therefore, this is a freature regression of virsh dump. Now qemu has support dumping memory in kdump-compressed format. This patch is adding new

[libvirt] [PATCH v5 1/3] add new virDomainCoreDumpWithFormat API

2014-03-06 Thread qiaonuo...@cn.fujitsu.com
--memory-only option is introduced without compression supported. Therefore, this is a freature regression of virsh dump. Now qemu has support dumping memory in kdump-compressed format. This patch is adding new virDomainCoreDumpWithFormat API, so that the format in which qemu dump domain's memory