Re: [libvirt] [PATCH v5 2/5] vz: add migration backbone code

2015-10-15 Thread Nikolay Shirokovskiy
In short, may be factor out common p2p code that now resides in libvirt-domain.c and reuse it for vz? Looks like vz driver is not a good place for such common and kinda complicated code. On 11.09.2015 14:06, Nikolay Shirokovskiy wrote: > > > On 11.09.2015 12:28, Daniel P. Berrange wrote: >> On

Re: [libvirt] [PATCH v5 2/5] vz: add migration backbone code

2015-09-11 Thread Nikolay Shirokovskiy
> As mentioned in the previous review, I really want to see VZ > provide the full set of drive callbacks required by the V3 > migration protocol, not just those you happen to need to have > today. ie add Begin, Finish & Confirm. This in turn makes it > quite easy to support non-P2P mode which is

Re: [libvirt] [PATCH v5 2/5] vz: add migration backbone code

2015-09-11 Thread Daniel P. Berrange
On Fri, Sep 11, 2015 at 12:05:54PM +0300, Nikolay Shirokovskiy wrote: > > > As mentioned in the previous review, I really want to see VZ > > provide the full set of drive callbacks required by the V3 > > migration protocol, not just those you happen to need to have > > today. ie add Begin, Finish

Re: [libvirt] [PATCH v5 2/5] vz: add migration backbone code

2015-09-11 Thread Nikolay Shirokovskiy
On 11.09.2015 12:28, Daniel P. Berrange wrote: > On Fri, Sep 11, 2015 at 12:05:54PM +0300, Nikolay Shirokovskiy wrote: >> >>> As mentioned in the previous review, I really want to see VZ >>> provide the full set of drive callbacks required by the V3 >>> migration protocol, not just those you

Re: [libvirt] [PATCH v5 2/5] vz: add migration backbone code

2015-09-09 Thread Daniel P. Berrange
On Fri, Sep 04, 2015 at 05:18:03PM +0300, Nikolay Shirokovskiy wrote: > From: nshirokovs...@virtuozzo.com > > This patch makes basic vz migration possible. For example by virsh: > > virsh -c vz:///system migrate $NAME vz+ssh://$DST/system --p2p > > Vz migration is

[libvirt] [PATCH v5 2/5] vz: add migration backbone code

2015-09-04 Thread Nikolay Shirokovskiy
From: nshirokovs...@virtuozzo.com This patch makes basic vz migration possible. For example by virsh: virsh -c vz:///system migrate $NAME vz+ssh://$DST/system --p2p Vz migration is implemented as p2p migration. The reason is that vz sdk do all the job. The question