Re: [libvirt] [PATCH v5 2/6] nodedev: udev: Convert udev private data to a lockable object

2017-10-18 Thread Erik Skultety
[...] > > +struct _udevEventData { > > +virObjectLockable parent; > > + > > struct udev_monitor *udev_monitor; > > int watch; > > bool privileged; > > }; > > Mental note - maybe the driver->privateData should change to > driver->udevEventData in _virNodeDeviceDriverState I

Re: [libvirt] [PATCH v5 2/6] nodedev: udev: Convert udev private data to a lockable object

2017-10-15 Thread John Ferlan
On 10/11/2017 10:52 AM, Erik Skultety wrote: > Since there's going to be a worker thread which needs to have some data > protected by a lock, the whole code would just simply get unnecessary > complex, since two sets of locks would be necessary, driver lock (for > udev monitor and event handle)

[libvirt] [PATCH v5 2/6] nodedev: udev: Convert udev private data to a lockable object

2017-10-11 Thread Erik Skultety
Since there's going to be a worker thread which needs to have some data protected by a lock, the whole code would just simply get unnecessary complex, since two sets of locks would be necessary, driver lock (for udev monitor and event handle) and a mutex protecting thread-local data. Given the