Re: [libvirt] [PATCH v5 3/4] qemu: Build correct command line for PCI NICs on ARM

2015-08-10 Thread Cole Robinson
On 08/10/2015 12:29 PM, Laine Stump wrote: > On 07/17/2015 07:27 AM, Pavel Fedin wrote: >> Legacy -net option works correctly only with embedded device models, which >> do not require any bus specification. Therefore, we should use -device for >> PCI hardware > > This function is starting to look

Re: [libvirt] [PATCH v5 3/4] qemu: Build correct command line for PCI NICs on ARM

2015-08-10 Thread Laine Stump
On 07/17/2015 07:27 AM, Pavel Fedin wrote: > Legacy -net option works correctly only with embedded device models, which > do not require any bus specification. Therefore, we should use -device for > PCI hardware This function is starting to look a bit like a hack on top of a hack on top of a hack.

[libvirt] [PATCH v5 3/4] qemu: Build correct command line for PCI NICs on ARM

2015-07-17 Thread Pavel Fedin
Legacy -net option works correctly only with embedded device models, which do not require any bus specification. Therefore, we should use -device for PCI hardware Signed-off-by: Pavel Fedin --- src/qemu/qemu_command.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu