Re: [libvirt] [PATCH v5 4/4] qemu: unlink the error report from VIR_STRDUP.

2018-09-06 Thread Ján Tomko
The '.' at the end of the summary is not necessary On Wed, Sep 05, 2018 at 01:20:56AM -0300, Julio Faracco wrote: The function to retrieve the file system info using QEMU-GA is using some conditionals to retrieve the info. This is wrong because the error of some conditionals will be raised if

Re: [libvirt] [PATCH v5 4/4] qemu: unlink the error report from VIR_STRDUP.

2018-09-05 Thread John Ferlan
On 09/05/2018 12:20 AM, Julio Faracco wrote: > The function to retrieve the file system info using QEMU-GA is using > some conditionals to retrieve the info. This is wrong because the error > of some conditionals will be raised if VIR_STRDUP return errors and not > if some problem occurred with

[libvirt] [PATCH v5 4/4] qemu: unlink the error report from VIR_STRDUP.

2018-09-04 Thread Julio Faracco
The function to retrieve the file system info using QEMU-GA is using some conditionals to retrieve the info. This is wrong because the error of some conditionals will be raised if VIR_STRDUP return errors and not if some problem occurred with JSON. Signed-off-by: Julio Faracco ---