Re: [libvirt] [PATCH v5 5/7] qemu: Add bps_max and friends QMP suport

2014-10-27 Thread Matthias Gatto
On Sat, Oct 25, 2014 at 6:30 AM, Eric Blake ebl...@redhat.com wrote: On 10/07/2014 05:14 AM, Matthias Gatto wrote: Detect if the the qemu binary currently in use suport the bps_max option, If yes add it to the command, if not, just ignore the options. Ignoring options is wrong. If a user

Re: [libvirt] [PATCH v5 5/7] qemu: Add bps_max and friends QMP suport

2014-10-27 Thread Eric Blake
On 10/27/2014 09:51 AM, Matthias Gatto wrote: On Sat, Oct 25, 2014 at 6:30 AM, Eric Blake ebl...@redhat.com wrote: On 10/07/2014 05:14 AM, Matthias Gatto wrote: Detect if the the qemu binary currently in use suport the bps_max option, s/suport/supports/ If yes add it to the command, if not,

Re: [libvirt] [PATCH v5 5/7] qemu: Add bps_max and friends QMP suport

2014-10-24 Thread Eric Blake
On 10/07/2014 05:14 AM, Matthias Gatto wrote: Detect if the the qemu binary currently in use suport the bps_max option, If yes add it to the command, if not, just ignore the options. Ignoring options is wrong. If a user explicitly requested something in XML but the hypervisor cannot honor it,

[libvirt] [PATCH v5 5/7] qemu: Add bps_max and friends QMP suport

2014-10-07 Thread Matthias Gatto
Detect if the the qemu binary currently in use suport the bps_max option, If yes add it to the command, if not, just ignore the options. Signed-off-by: Matthias Gatto matthias.ga...@outscale.com --- src/qemu/qemu_monitor_json.c | 57 +++- 1 file changed,