Re: [libvirt] [PATCH v5 7/9] tests: check CPU features handling in libxl driver

2018-03-19 Thread Daniel P . Berrangé
On Mon, Mar 19, 2018 at 04:14:20PM +0100, Marek Marczykowski-Górecki wrote: > On Mon, Mar 19, 2018 at 02:11:02PM +, Daniel P. Berrangé wrote: > > On Fri, Mar 16, 2018 at 08:54:42PM +0100, Marek Marczykowski-Górecki wrote: > > > On Fri, Mar 16, 2018 at 05:44:28PM +, Daniel P. Berrangé

Re: [libvirt] [PATCH v5 7/9] tests: check CPU features handling in libxl driver

2018-03-19 Thread Marek Marczykowski-Górecki
On Mon, Mar 19, 2018 at 02:11:02PM +, Daniel P. Berrangé wrote: > On Fri, Mar 16, 2018 at 08:54:42PM +0100, Marek Marczykowski-Górecki wrote: > > On Fri, Mar 16, 2018 at 05:44:28PM +, Daniel P. Berrangé wrote: > > > Since Xen lets you specify raw "cpuid" register values here, surely > > >

Re: [libvirt] [PATCH v5 7/9] tests: check CPU features handling in libxl driver

2018-03-19 Thread Daniel P . Berrangé
On Fri, Mar 16, 2018 at 08:54:42PM +0100, Marek Marczykowski-Górecki wrote: > On Fri, Mar 16, 2018 at 05:44:28PM +, Daniel P. Berrangé wrote: > > Since Xen lets you specify raw "cpuid" register values here, surely > > this is flexible enough to allow us to support the mode=custom CPU > >

Re: [libvirt] [PATCH v5 7/9] tests: check CPU features handling in libxl driver

2018-03-16 Thread Marek Marczykowski-Górecki
On Fri, Mar 16, 2018 at 05:44:28PM +, Daniel P. Berrangé wrote: > Since Xen lets you specify raw "cpuid" register values here, surely > this is flexible enough to allow us to support the mode=custom CPU > models ? > > We would just need to make sure every bit poisition used either > 0 or 1,

Re: [libvirt] [PATCH v5 7/9] tests: check CPU features handling in libxl driver

2018-03-16 Thread Daniel P . Berrangé
On Wed, Mar 14, 2018 at 03:26:14AM +0100, Marek Marczykowski-Górecki wrote: > Test enabling/disabling individual CPU features and also setting > nested HVM support, which is also controlled by CPU features node. > > Signed-off-by: Marek Marczykowski-Górecki >

[libvirt] [PATCH v5 7/9] tests: check CPU features handling in libxl driver

2018-03-15 Thread Marek Marczykowski-Górecki
Test enabling/disabling individual CPU features and also setting nested HVM support, which is also controlled by CPU features node. Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Jim Fehlig --- Changes since v3: - adjust for modified