Re: [libvirt] [PATCH v5.1 04/11] qemu: Record the default NIC model in the domain XML

2013-04-05 Thread Peter Krempa
On 04/05/13 09:37, Viktor Mihajlovski wrote: On 04/04/2013 09:50 PM, Peter Krempa wrote: I don't know if the realtek card works on the s390 qemu too, but if it doesn't I don't mind changing it to virtio. In case it does work, we need to consider if we aren't regressing here. commit 539d73d i

Re: [libvirt] [PATCH v5.1 04/11] qemu: Record the default NIC model in the domain XML

2013-04-05 Thread Viktor Mihajlovski
On 04/04/2013 09:50 PM, Peter Krempa wrote: I don't know if the realtek card works on the s390 qemu too, but if it doesn't I don't mind changing it to virtio. In case it does work, we need to consider if we aren't regressing here. commit 539d73d intercepts this global defaulting but relies on

Re: [libvirt] [PATCH v5.1 04/11] qemu: Record the default NIC model in the domain XML

2013-04-04 Thread Peter Krempa
On 04/04/13 17:35, Viktor Mihajlovski wrote: On 04/04/2013 02:10 PM, Peter Krempa wrote: This patch implements the devices post parse cllback and uses it to fill the default qemu network card model into the XML if none is specified. Libvirt assumes that the network card model for qemu is the "r

Re: [libvirt] [PATCH v5.1 04/11] qemu: Record the default NIC model in the domain XML

2013-04-04 Thread Eric Blake
On 04/04/2013 06:10 AM, Peter Krempa wrote: > This patch implements the devices post parse cllback and uses it to fill s/cllback/callback/ > the default qemu network card model into the XML if none is specified. > > Libvirt assumes that the network card model for qemu is the "rtl8139". > Record

Re: [libvirt] [PATCH v5.1 04/11] qemu: Record the default NIC model in the domain XML

2013-04-04 Thread Daniel P. Berrange
On Thu, Apr 04, 2013 at 02:10:14PM +0200, Peter Krempa wrote: > This patch implements the devices post parse cllback and uses it to fill > the default qemu network card model into the XML if none is specified. > > Libvirt assumes that the network card model for qemu is the "rtl8139". > Record this

Re: [libvirt] [PATCH v5.1 04/11] qemu: Record the default NIC model in the domain XML

2013-04-04 Thread Viktor Mihajlovski
On 04/04/2013 02:10 PM, Peter Krempa wrote: > This patch implements the devices post parse cllback and uses it to fill > the default qemu network card model into the XML if none is specified. > > Libvirt assumes that the network card model for qemu is the "rtl8139". > Record this in the XML using

[libvirt] [PATCH v5.1 04/11] qemu: Record the default NIC model in the domain XML

2013-04-04 Thread Peter Krempa
This patch implements the devices post parse cllback and uses it to fill the default qemu network card model into the XML if none is specified. Libvirt assumes that the network card model for qemu is the "rtl8139". Record this in the XML using the new callback to avoid user confusion. --- src/qem