Re: [libvirt] [PATCH v6] npiv: Auto-generate WWN if it's not specified

2012-02-09 Thread Eric Blake
On 02/07/2012 07:03 AM, Osier Yang wrote: I don't like this interface - it makes virrandom.c know too much. A better interface would be: virRandomGenerateWWN(char **wwn, const char *oui) where the caller is responsible for determining the appropriate OUI for the hypervisor to be passed in.

Re: [libvirt] [PATCH v6] npiv: Auto-generate WWN if it's not specified

2012-02-09 Thread Osier Yang
On 2012年02月10日 07:05, Eric Blake wrote: On 02/07/2012 07:03 AM, Osier Yang wrote: I don't like this interface - it makes virrandom.c know too much. A better interface would be: virRandomGenerateWWN(char **wwn, const char *oui) where the caller is responsible for determining the appropriate

Re: [libvirt] [PATCH v6] npiv: Auto-generate WWN if it's not specified

2012-02-08 Thread Osier Yang
On 2012年02月07日 22:03, Osier Yang wrote: On 2012年02月07日 21:29, Eric Blake wrote: On 02/07/2012 06:38 AM, Osier Yang wrote: The auto-generated WWN comply with the new addressing schema of WWN: quote the first nibble is either hex 5 or 6 followed by a 3-byte vendor identifier and 36 bits for a

[libvirt] [PATCH v6] npiv: Auto-generate WWN if it's not specified

2012-02-07 Thread Osier Yang
The auto-generated WWN comply with the new addressing schema of WWN: quote the first nibble is either hex 5 or 6 followed by a 3-byte vendor identifier and 36 bits for a vendor-specified serial number. /quote We choose hex 5 for the first nibble. And for the 3-bytes vendor ID, we uses the OUI

Re: [libvirt] [PATCH v6] npiv: Auto-generate WWN if it's not specified

2012-02-07 Thread Matthias Bolte
2012/2/7 Osier Yang jy...@redhat.com: The auto-generated WWN comply with the new addressing schema of WWN: quote the first nibble is either hex 5 or 6 followed by a 3-byte vendor identifier and 36 bits for a vendor-specified serial number. /quote We choose hex 5 for the first nibble. And

Re: [libvirt] [PATCH v6] npiv: Auto-generate WWN if it's not specified

2012-02-07 Thread Eric Blake
On 02/07/2012 06:38 AM, Osier Yang wrote: The auto-generated WWN comply with the new addressing schema of WWN: quote the first nibble is either hex 5 or 6 followed by a 3-byte vendor identifier and 36 bits for a vendor-specified serial number. /quote We choose hex 5 for the first nibble.

Re: [libvirt] [PATCH v6] npiv: Auto-generate WWN if it's not specified

2012-02-07 Thread Osier Yang
On 2012年02月07日 21:29, Eric Blake wrote: On 02/07/2012 06:38 AM, Osier Yang wrote: The auto-generated WWN comply with the new addressing schema of WWN: quote the first nibble is either hex 5 or 6 followed by a 3-byte vendor identifier and 36 bits for a vendor-specified serial number. /quote We

Re: [libvirt] [PATCH v6] npiv: Auto-generate WWN if it's not specified

2012-02-07 Thread Osier Yang
On 2012年02月07日 21:15, Matthias Bolte wrote: 2012/2/7 Osier Yangjy...@redhat.com: The auto-generated WWN comply with the new addressing schema of WWN: quote the first nibble is either hex 5 or 6 followed by a 3-byte vendor identifier and 36 bits for a vendor-specified serial number. /quote We