Re: [libvirt] [PATCH v6 1/9] Revert "snapshot: Add virDomainSnapshotObjListParse"

2019-03-26 Thread Daniel P . Berrangé
On Tue, Mar 26, 2019 at 01:13:45AM -0500, Eric Blake wrote: > This reverts commit 1b57269cbcfcfe998a065c0c9f0f8db408710d87, and > subsequent refactorings of the function into new files. There are no > callers of this function - I had originally proposed it for > implementing a new bulk snapshot

Re: [libvirt] [PATCH v6 1/9] Revert "snapshot: Add virDomainSnapshotObjListParse"

2019-03-26 Thread Ján Tomko
On Tue, Mar 26, 2019 at 01:13:45AM -0500, Eric Blake wrote: This reverts commit 1b57269cbcfcfe998a065c0c9f0f8db408710d87, and subsequent refactorings of the function into new files. There are no callers of this function - I had originally proposed it for implementing a new bulk snapshot API,

[libvirt] [PATCH v6 1/9] Revert "snapshot: Add virDomainSnapshotObjListParse"

2019-03-26 Thread Eric Blake
This reverts commit 1b57269cbcfcfe998a065c0c9f0f8db408710d87, and subsequent refactorings of the function into new files. There are no callers of this function - I had originally proposed it for implementing a new bulk snapshot API, but that proved to be too invasive given RPC limits. I also