Re: [libvirt] [PATCH v6 10/17] qemu: auto-add pcie-root-port/dmi-to-pci-bridge controllers as needed

2016-11-14 Thread Andrea Bolognani
On Sun, 2016-11-13 at 10:55 -0500, Laine Stump wrote: > > 2) pci-bridge was requested with user-supplied address that is on a  > > nonexistent bus, and that bus number is >1 over the current last bus  > > (i.e. there is a gap in the controller indexes). This would happen if,  > > for example,

Re: [libvirt] [PATCH v6 10/17] qemu: auto-add pcie-root-port/dmi-to-pci-bridge controllers as needed

2016-11-13 Thread Laine Stump
On 11/11/2016 11:09 AM, Laine Stump wrote: On 11/10/2016 09:10 AM, Andrea Bolognani wrote: On Wed, 2016-11-09 at 15:23 -0500, Laine Stump wrote: +} else if (flags & VIR_PCI_CONNECT_TYPE_PCI_BRIDGE && + addrs->buses[0].model == VIR_DOMAIN_CONTROLLER_MODEL_PCIE_ROOT) { +

Re: [libvirt] [PATCH v6 10/17] qemu: auto-add pcie-root-port/dmi-to-pci-bridge controllers as needed

2016-11-11 Thread Laine Stump
On 11/10/2016 09:10 AM, Andrea Bolognani wrote: On Wed, 2016-11-09 at 15:23 -0500, Laine Stump wrote: +} else if (flags & VIR_PCI_CONNECT_TYPE_PCI_BRIDGE && + addrs->buses[0].model == VIR_DOMAIN_CONTROLLER_MODEL_PCIE_ROOT) { +model =

Re: [libvirt] [PATCH v6 10/17] qemu: auto-add pcie-root-port/dmi-to-pci-bridge controllers as needed

2016-11-10 Thread Andrea Bolognani
On Wed, 2016-11-09 at 15:23 -0500, Laine Stump wrote: > > > +} else if (flags & VIR_PCI_CONNECT_TYPE_PCI_BRIDGE && > > > +   addrs->buses[0].model == > > > VIR_DOMAIN_CONTROLLER_MODEL_PCIE_ROOT) { > > > +model = VIR_DOMAIN_CONTROLLER_MODEL_DMI_TO_PCI_BRIDGE; > >  > > Mh,

Re: [libvirt] [PATCH v6 10/17] qemu: auto-add pcie-root-port/dmi-to-pci-bridge controllers as needed

2016-11-09 Thread Laine Stump
On 11/09/2016 09:19 AM, Andrea Bolognani wrote: On Mon, 2016-11-07 at 14:50 -0500, Laine Stump wrote: Previously libvirt would only add pci-bridge devices automatically when an address was requested for a device that required a legacy PCI slot and none was available. This patch expands that

Re: [libvirt] [PATCH v6 10/17] qemu: auto-add pcie-root-port/dmi-to-pci-bridge controllers as needed

2016-11-09 Thread Andrea Bolognani
On Mon, 2016-11-07 at 14:50 -0500, Laine Stump wrote: > Previously libvirt would only add pci-bridge devices automatically > when an address was requested for a device that required a legacy PCI > slot and none was available. This patch expands that support to > dmi-to-pci-bridge (which is needed

[libvirt] [PATCH v6 10/17] qemu: auto-add pcie-root-port/dmi-to-pci-bridge controllers as needed

2016-11-07 Thread Laine Stump
Previously libvirt would only add pci-bridge devices automatically when an address was requested for a device that required a legacy PCI slot and none was available. This patch expands that support to dmi-to-pci-bridge (which is needed in order to add a pci-bridge on a machine with a pcie-root),