Re: [libvirt] [PATCH v6 5/9] nodedev: udev: Unlock the private data before setting up 'system' node

2017-10-19 Thread John Ferlan
On 10/19/2017 02:54 AM, Erik Skultety wrote: > On Wed, Oct 18, 2017 at 05:13:41PM -0400, John Ferlan wrote: >> >> >> On 10/18/2017 09:52 AM, Erik Skultety wrote: >>> udevSetupSystemDev only needs the udev data lock to be locked because of >>> calling udevGetDMIData which accesses some protected s

Re: [libvirt] [PATCH v6 5/9] nodedev: udev: Unlock the private data before setting up 'system' node

2017-10-18 Thread Erik Skultety
On Wed, Oct 18, 2017 at 05:13:41PM -0400, John Ferlan wrote: > > > On 10/18/2017 09:52 AM, Erik Skultety wrote: > > udevSetupSystemDev only needs the udev data lock to be locked because of > > calling udevGetDMIData which accesses some protected structure members, > > but it can do that on its own

Re: [libvirt] [PATCH v6 5/9] nodedev: udev: Unlock the private data before setting up 'system' node

2017-10-18 Thread John Ferlan
On 10/18/2017 09:52 AM, Erik Skultety wrote: > udevSetupSystemDev only needs the udev data lock to be locked because of > calling udevGetDMIData which accesses some protected structure members, > but it can do that on its own just fine, no need to hold the lock the > whole time. > > Signed-off-b

[libvirt] [PATCH v6 5/9] nodedev: udev: Unlock the private data before setting up 'system' node

2017-10-18 Thread Erik Skultety
udevSetupSystemDev only needs the udev data lock to be locked because of calling udevGetDMIData which accesses some protected structure members, but it can do that on its own just fine, no need to hold the lock the whole time. Signed-off-by: Erik Skultety --- src/node_device/node_device_udev.c |