Re: [libvirt] [PATCH v6 8/9] backup: Introduce virDomainBackup APIs

2019-03-26 Thread Eric Blake
On 3/26/19 1:13 PM, Eric Blake wrote: TL;DR: After more thought, I'm reluctant to make a domain job an opaque type. I'm also leaning towards withdrawing virDomainListJobIds() from the set of APIs I'm proposing for 5.2, on the grounds that with a documented magic job id of '0' that means "the

Re: [libvirt] [PATCH v6 8/9] backup: Introduce virDomainBackup APIs

2019-03-26 Thread Eric Blake
On 3/26/19 12:08 PM, Daniel P. Berrangé wrote: > On Tue, Mar 26, 2019 at 01:13:52AM -0500, Eric Blake wrote: >> Introduce a few more new public APIs related to incremental backups. >> This builds on the previous notion of a checkpoint (without an >> existing checkpoint, the new API is a full

Re: [libvirt] [PATCH v6 8/9] backup: Introduce virDomainBackup APIs

2019-03-26 Thread Daniel P . Berrangé
On Tue, Mar 26, 2019 at 01:13:52AM -0500, Eric Blake wrote: > Introduce a few more new public APIs related to incremental backups. > This builds on the previous notion of a checkpoint (without an > existing checkpoint, the new API is a full backup, differing from > virDomainBlockCopy in the point

[libvirt] [PATCH v6 8/9] backup: Introduce virDomainBackup APIs

2019-03-26 Thread Eric Blake
Introduce a few more new public APIs related to incremental backups. This builds on the previous notion of a checkpoint (without an existing checkpoint, the new API is a full backup, differing from virDomainBlockCopy in the point of time chosen and in operation on multiple disks at once); and also